diff options
| author |   Philipp <pmaier@sysmocom.de> | 2016-12-20 14:23:45 +0100 |
|---|---|---|
| committer |   Alexander Couzens <lynxis@fe80.eu> | 2017-01-31 17:03:04 +0100 |
| commit | ac509fe3b0c9f87d35aea3b080b5f76b03527702 (patch) | |
| tree | 50ba0cc38b33db549f76e75b8a603a91038cc532 | |
| parent | debian: Require libgtp-dev after the SO version bump (diff) | |
| download | OpenBSC-ac509fe3b0c9f87d35aea3b080b5f76b03527702.tar.xz OpenBSC-ac509fe3b0c9f87d35aea3b080b5f76b03527702.zip | |
gprs: T3186 encoding in Sysinfo 13
The timer T3186, which is described in 3GPP TS 44.060, is using 3
bits of the si13 mac block. This requires special encoding. In the
case of T3186, the value is encoded by the formula: bits = t/500-1.
Our implementation uses the formula bits=t/500, which is incorrect.
| -rw-r--r-- | openbsc/src/libbsc/rest_octets.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/openbsc/src/libbsc/rest_octets.c b/openbsc/src/libbsc/rest_octets.c index 6fae9cd87..ed6c573d5 100644 --- a/openbsc/src/libbsc/rest_octets.c +++ b/openbsc/src/libbsc/rest_octets.c @@ -566,6 +566,8 @@ static int append_gprs_mobile_alloc(struct bitvec *bv) static int encode_t3192(unsigned int t3192) { + /* See also 3GPP TS 44.060 + Table 12.24.2: GPRS Cell Options information element details */ if (t3192 == 0) return 3; else if (t3192 <= 80) @@ -645,7 +647,11 @@ static int append_gprs_cell_opt(struct bitvec *bv, return drx_timer_max; bitvec_set_uint(bv, gco->nmo, 2); - bitvec_set_uint(bv, gco->t3168 / 500, 3); + + /* See also 3GPP TS 44.060 + Table 12.24.2: GPRS Cell Options information element details */ + bitvec_set_uint(bv, gco->t3168 / 500 - 1, 3); + bitvec_set_uint(bv, t3192, 3); bitvec_set_uint(bv, drx_timer_max, 3); /* ACCESS_BURST_TYPE: Hard-code 8bit */ |