cgit/configfile.c, branch ch/git-2-54

configfile: fix EOF handling

2016-10-01T10:43:33Z

Currently we can end up passing EOF to isspace(), which is in fact libgit's sane_isspace which does: ((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0) It is very unlikely that EOF cast to "unsigned char" will end up in a character that has the GIT_SPACE bit set, but the standard only requires that EOF be a negative integer, so it could access any value in the sane_ctype array. If it does end up returning true for isspace() then this loop will never terminate, so handle EOF as a special value in the same way as the other loops in this function. Signed-off-by: John Keeping

configfile.c: don't include system headers directly

2015-08-13T13:37:28Z

git-compat-util.h may define various values that affect the interpretation of system headers. In most places we include cgit.h first, which pulls in git-compat-util.h, but this file does not depend on anything else in CGit, so use git-compat-util.h directly. Signed-off-by: John Keeping

Update copyright information

2014-01-08T14:10:49Z

* Name "cgit Development Team" as copyright holder to avoid listing every single developer. * Update copyright ranges. Signed-off-by: Lukas Fleischer

Use strbuf for reading configuration files

2013-08-12T19:14:10Z

Use struct strbuf from Git instead of fixed-size buffers to remove the limit on the length of configuration file lines and refactor read_config_line() to improve readability. Note that this also fixes a buffer overflow that existed with the original fixed-size buffer implementation. Signed-off-by: Lukas Fleischer

Mark several functions/variables static

2013-03-05T00:50:39Z

Spotted by parsing the output of `gcc -Wmissing-prototypes [...]`. Signed-off-by: Lukas Fleischer

White space around control verbs.

2013-03-04T14:12:54Z

Signed-off-by: Jason A. Donenfeld

Fix several whitespace errors

2013-03-04T00:12:48Z

* Remove whitespace at the end of lines. * Replace space indentation by tabs. * Add whitespace before/after several operators ("+", "-", "*", ...) * Add whitespace to assignments ("foo = bar;"). * Fix whitespace in parameter lists ("foobar(foo, bar, 42)"). Signed-off-by: Lukas Fleischer

Move function for configfile parsing into configfile.[ch]

2008-03-27T23:09:11Z

This is a generic function which wanted its own little object file. Signed-off-by: Lars Hjemli