cgit/filter.c, branch v1.3.1A hyperfast web frontend for git repositories written in C.https://git.zx2c4.com/cgit/atom/filter.c?h=v1.3.12026-05-04T21:03:51Zglobal: fix libc constness warnings2026-05-04T21:03:51ZJason A. DonenfeldJason@zx2c4.com2026-05-04T21:03:22Zurn:sha1:5a0f900569f421422bd7511a45c7346c7668e710
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
cgit: truncate all config values at the newline2026-05-04T16:28:27ZJason A. DonenfeldJason@zx2c4.com2026-05-04T16:13:13Zurn:sha1:ed05b1054df10a2fbc68000cfdd429daec03a456
These would be largely invalid anyway (save, I suppose, for Linux file
paths that technically can contain new lines).
The actual problem is that these get printed back out into cached -- and
trusted -- cgitrc files, and if the fields have newlines, the git-config
way of less trusted users configuring repos on a shared system can be
abused to inject newlines, which then can be used to smuggle global
options (including filters, which execute code) into the cached cgitrc.
So now, only ever duplicate up to the newline, when dealing with these
inputs.
Reported-by: Adrian Denkiewicz <adrian@doyensec.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
fix building with clang2024-07-16T11:26:10ZDenis Pronindannftk@yandex.ru2024-06-09T06:41:36Zurn:sha1:fb87de795b9f1b1e21825243716ff1156097adf2
fix error that is given because of macro overlapping cgit_filter member:
../filter.c:388:10: error: no member named '__fprintf_chk' in
'struct cgit_filter'
388 | filter->fprintf(filter, f, prefix);
| ~~~~~~ ^
/usr/include/bits/stdio2.h:92:3: note: expanded from macro 'fprintf'
92 | __fprintf_chk (stream, __USE_FORTIFY_LEVEL - 1, __VA_ARGS__)
| ^
1 error generated.
Signed-off-by: Denis Pronin <dannftk@yandex.ru>
Signed-off-by: Christian Hesse <mail@eworm.de>
filter: pipe_fh should be local2017-10-14T14:13:07ZJason A. DonenfeldJason@zx2c4.com2017-10-14T14:13:07Zurn:sha1:fd069b4ca08cb46eb335a1434330b21fbaf84b9c
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
filter: don't use dlsym unnecessarily2015-08-13T13:39:06ZJohn Keepingjohn@keeping.me.uk2015-08-13T11:14:20Zurn:sha1:0c4d76755b98bb597279a1930bf4c69eca7dde62
We only need to hook write() if Lua filter's are in use. If support has
been disabled, remove the dependency on dlsym().
Signed-off-by: John Keeping <john@keeping.me.uk>
Remove redundant includes2015-08-13T13:36:53ZJohn Keepingjohn@keeping.me.uk2015-08-13T11:14:15Zurn:sha1:157f544ac2149a985b0f62e9381a759c0ae252ec
These are all included in git-compat-util.h (when necessary), which we
include in cgit.h.
Signed-off-by: John Keeping <john@keeping.me.uk>
Avoid non-ANSI function declarations2015-03-09T16:38:30ZJohn Keepingjohn@keeping.me.uk2015-03-08T16:32:16Zurn:sha1:e3d3fffdd447cdb4551549faae65bae5353a2cab
Sparse says things like:
warning: non-ANSI function declaration of function 'calc_ttl'
Signed-off-by: John Keeping <john@keeping.me.uk>
repolist: add owner-filter2014-12-24T02:08:20ZChris Burroughschris.burroughs@gmail.com2014-08-04T13:23:08Zurn:sha1:96ceb9a95a7a321209cff347fefd141a9fffc7ca
This allows custom links to be used for repository owners by
configuring a filter to be applied in the "Owner" column in the
repository list.
remove trailing whitespaces from source files2014-04-17T10:55:09ZChristian Hessemail@eworm.de2014-04-17T09:55:46Zurn:sha1:b431282c91deea24916578395d88084261410968filter: don't forget to reap the auth filter2014-01-17T12:53:02ZJason A. DonenfeldJason@zx2c4.com2014-01-17T12:53:02Zurn:sha1:9786f4613da38cb263e76263370d7816a9347149
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>