aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2011-06-02 10:30:26 +0000
committerLars Hjemli <hjemli@gmail.com>2011-06-02 10:30:26 +0000
commitd885158f6ac29e04bd14dd132331c7e3a93e7490 (patch)
tree15dee6a8e4f3cfd2737a50725e480d09220ee0dd
parentui-snapshot.c: remove debug cruft (diff)
downloadcgit-d885158f6ac29e04bd14dd132331c7e3a93e7490.tar.xz
cgit-d885158f6ac29e04bd14dd132331c7e3a93e7490.zip
ui-log.c: do not link from age column
The link url wasn't properly escaped, and since the link was identical to the one used on the commit message it didn't serve any special purpose. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rwxr-xr-xtests/t0103-log.sh2
-rw-r--r--ui-log.c9
2 files changed, 1 insertions, 10 deletions
diff --git a/tests/t0103-log.sh b/tests/t0103-log.sh
index def5c18..75dd761 100755
--- a/tests/t0103-log.sh
+++ b/tests/t0103-log.sh
@@ -18,7 +18,7 @@ run_test 'generate "with%20space/log?qt=grep&q=commit+1"' '
run_test 'find commit 1' 'grep -e "commit 1" trash/tmp'
run_test 'find link with %20 in path' 'grep -e "/with%20space/log/?qt=grep" trash/tmp'
run_test 'find link with + in arg' 'grep -e "/log/?qt=grep&q=commit+1" trash/tmp'
-run_test BUG 'no links with space in path' '! grep -e "href=./with space/" trash/tmp'
+run_test 'no links with space in path' '! grep -e "href=./with space/" trash/tmp'
run_test 'no links with space in arg' '! grep -e "q=commit 1" trash/tmp'
run_test 'commit 2 is not visible' '! grep -e "commit 2" trash/tmp'
diff --git a/ui-log.c b/ui-log.c
index 8add66a..15ed6a3 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -95,7 +95,6 @@ void show_commit_decorations(struct commit *commit)
void print_commit(struct commit *commit, struct rev_info *revs)
{
struct commitinfo *info;
- char *tmp;
int cols = revs->graph ? 3 : 2;
struct strbuf graphbuf = STRBUF_INIT;
struct strbuf msgbuf = STRBUF_INIT;
@@ -130,11 +129,7 @@ void print_commit(struct commit *commit, struct rev_info *revs)
}
else {
html("<td>");
- tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1));
- tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp);
- html_link_open(tmp, NULL, NULL);
cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
- html_link_close();
html("</td>");
}
@@ -172,11 +167,7 @@ void print_commit(struct commit *commit, struct rev_info *revs)
if (revs->graph) {
html("</td><td>");
- tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1));
- tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp);
- html_link_open(tmp, NULL, NULL);
cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
- html_link_close();
}
if (ctx.repo->enable_log_filecount) {