diff options
| author |   Jim Meyering <meyering@redhat.com> | 2011-02-28 12:18:57 +0100 |
|---|---|---|
| committer |   Lars Hjemli <hjemli@gmail.com> | 2011-03-05 13:38:34 +0100 |
| commit | fc384b16fb9787380746000d3cea2d53fccc548e (patch) | |
| tree | d0a77d911c111e49904ab2f5061af22417f2b698 /cgit.c | |
| parent | ui-shared: silence warning (diff) | |
| download | cgit-fc384b16fb9787380746000d3cea2d53fccc548e.tar.xz cgit-fc384b16fb9787380746000d3cea2d53fccc548e.zip | |
do not infloop on a query ending in %XY, for invalid hex X or Y
When a query ends in say %gg, (or any invalid hex) e.g.,
http://git.gnome.org/browse/gdlmm/commit/?id=%gg
convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns
txt-1, so the loop in http_parse_querystring never terminates. The
solution is to make the memmove also copy the trailing NUL.
* html.c (convert_query_hexchar): Fix off-by-one error.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions