aboutsummaryrefslogtreecommitdiffstats
path: root/html.c
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2011-02-28 12:18:57 +0100
committerLars Hjemli <hjemli@gmail.com>2011-03-05 13:38:34 +0100
commitfc384b16fb9787380746000d3cea2d53fccc548e (patch)
treed0a77d911c111e49904ab2f5061af22417f2b698 /html.c
parentui-shared: silence warning (diff)
downloadcgit-fc384b16fb9787380746000d3cea2d53fccc548e.tar.xz
cgit-fc384b16fb9787380746000d3cea2d53fccc548e.zip
do not infloop on a query ending in %XY, for invalid hex X or Y
When a query ends in say %gg, (or any invalid hex) e.g., http://git.gnome.org/browse/gdlmm/commit/?id=%gg convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns txt-1, so the loop in http_parse_querystring never terminates. The solution is to make the memmove also copy the trailing NUL. * html.c (convert_query_hexchar): Fix off-by-one error. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'html.c')
-rw-r--r--html.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/html.c b/html.c
index d86b2c1..5336596 100644
--- a/html.c
+++ b/html.c
@@ -249,7 +249,7 @@ char *convert_query_hexchar(char *txt)
d1 = hextoint(*(txt+1));
d2 = hextoint(*(txt+2));
if (d1<0 || d2<0) {
- memmove(txt, txt+3, n-3);
+ memmove(txt, txt+3, n-2);
return txt-1;
} else {
*txt = d1 * 16 + d2;