path: root/ui-shared.c
diff options
authorLars Hjemli <hjemli@gmail.com>2009-01-11 21:23:04 +0100
committerLars Hjemli <hjemli@gmail.com>2009-01-11 21:23:04 +0100
commiteb14609dc46461728a065c0a243b338fc32fd762 (patch)
treef00563342db8859f46ac8141fdaa5d4e17eb940e /ui-shared.c
parentui-tag: escape tagnames properly (diff)
Avoid SEGFAULT on invalid requests
When an unknown page is requested, either on the querystring or via PATH_INFO, we end up with a null-referencing cgit_cmd. This null- pointer is then used as argument to the hc() function (which decides what tab to render as 'active'), but this function failed to check if a valid cmd was specified and a SEGFAULT would occur. This patch fixes the issue by introducing a 'fallback-cmd' which specifies what tab to render as 'active' when no valid cmd is requested. While at it, we now also keep track of the active repository even if an invalid cmd was requested since we want to show the error message about the invalid request in the correct context. Noticed-by: Robin Redeker <elmex@ta-sa.org> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'ui-shared.c')
1 files changed, 6 insertions, 1 deletions
diff --git a/ui-shared.c b/ui-shared.c
index 224e5f3..76cd00d 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -577,15 +577,20 @@ void add_hidden_formfields(int incl_head, int incl_search, char *page)
+const char *fallback_cmd = "repolist";
char *hc(struct cgit_cmd *cmd, const char *page)
- return (strcmp(cmd->name, page) ? NULL : "active");
+ return (strcmp(cmd ? cmd->name : fallback_cmd, page) ? NULL : "active");
void cgit_print_pageheader(struct cgit_context *ctx)
struct cgit_cmd *cmd = cgit_get_cmd(ctx);
+ if (!cmd && ctx->repo)
+ fallback_cmd = "summary";
html("<table id='header'>\n");
html("<td class='logo' rowspan='2'><a href='");