diff options
author | John Keeping <john@keeping.me.uk> | 2014-01-12 17:13:50 +0000 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2014-01-12 20:20:20 +0100 |
commit | 3d8a6507ca542881a5e8b30ad6b7068a9c4fdeea (patch) | |
tree | f95c74d3317546606d72b74db3082769515c5e33 /ui-tree.c | |
parent | ui-snapshot: set unused cgit_filter fields to zero (diff) | |
download | cgit-3d8a6507ca542881a5e8b30ad6b7068a9c4fdeea.tar.xz cgit-3d8a6507ca542881a5e8b30ad6b7068a9c4fdeea.zip |
filter: pass extra arguments via cgit_open_filter
This avoids poking into the filter data structure at various points in
the code. We rely on the fact that the number of arguments is fixed
based on the filter type (set in cgit_new_filter) and that the call
sites all know which filter type they're using.
Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'ui-tree.c')
-rw-r--r-- | ui-tree.c | 7 |
1 files changed, 3 insertions, 4 deletions
@@ -45,13 +45,12 @@ static void print_text_buffer(const char *name, char *buf, unsigned long size) } if (ctx.repo->source_filter) { + char *filter_arg = xstrdup(name); html("<td class='lines'><pre><code>"); - ctx.repo->source_filter->argv[1] = xstrdup(name); - cgit_open_filter(ctx.repo->source_filter); + cgit_open_filter(ctx.repo->source_filter, filter_arg); html_raw(buf, size); cgit_close_filter(ctx.repo->source_filter); - free(ctx.repo->source_filter->argv[1]); - ctx.repo->source_filter->argv[1] = NULL; + free(filter_arg); html("</code></pre></td></tr></table>\n"); return; } |