aboutsummaryrefslogtreecommitdiffstats
path: root/ui-refs.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2016-10-01Makefile: remove extra spaceJason A. Donenfeld1-1/+1
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-10-01Simplify http_parse_querystring()Lukas Fleischer2-57/+11
Instead of reimplementing URL parameter parsing from scratch, use url_decode_parameter_name() and url_decode_parameter_value() which are already provided by Git. Also, change the return type of http_parse_querystring() to void since its only caller already ignores the return value. Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
2016-10-01ui-tree: remove a fixed size bufferJohn Keeping1-6/+9
As libgit.a moves away from using fixed size buffers, there is no guarantee that PATH_MAX is sufficient for all of the paths in a Git tree, so we should use a dynamically sized buffer here. Coverity-Id: 141884 Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01ui-tag: clean up taginfoJohn Keeping1-2/+4
Free the taginfo when we're done with it. Also reduce the scope of a couple of variables so that it's clear that this is the only path that uses the taginfo structure. Coverity-Id: 141883 Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01shared: make cgit_free_taginfo() publicJohn Keeping2-1/+2
We will use this function from ui-tag.c in the next patch. Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01shared: remove return value from cgit_free_commitinfo()John Keeping2-3/+2
This return value is never used and the function always returns NULL. Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01tree: allow skipping through single-child treesJohn Keeping1-2/+68
If we have only a single element in a directory (for example in Java package paths), display multiple directories in one go so that it is possible to navigate directly to the first directory that contains either files or multiple directories. Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01ui-ssdiff: fix decl-after-statement warningsJohn Keeping1-2/+2
git.git's coding style avoids decl-after-statement and we generally try to follow it but a few warnings have crept in recently. Fix the one in ui-ssdiff.c Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01ui-shared: fix decl-after-statement warningsJohn Keeping1-5/+7
git.git's coding style avoids decl-after-statement and we generally try to follow it but a few warnings have crept in recently. Fix the ones in ui-shared.c Signed-off-by: John Keeping <john@keeping.me.uk>
2016-10-01configfile: fix EOF handlingJohn Keeping1-1/+3
Currently we can end up passing EOF to isspace(), which is in fact libgit's sane_isspace which does: ((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0) It is very unlikely that EOF cast to "unsigned char" will end up in a character that has the GIT_SPACE bit set, but the standard only requires that EOF be a negative integer, so it could access any value in the sane_ctype array. If it does end up returning true for isspace() then this loop will never terminate, so handle EOF as a special value in the same way as the other loops in this function. Signed-off-by: John Keeping <john@keeping.me.uk>
2016-09-04git: update to v2.10.0Christian Hesse9-62/+62
Upstream continues to replace unsigned char *sha1 with struct object_id old_oid. This makes the required changes. The git lib has its own main function now. Rename our main function to cmd_main, it is called from main then.
2016-07-12Fix qry.head leak on errorRichard Maw1-4/+4
This is run soon before exiting so it wasn't leaked for long. Signed-off-by: Richard Maw <richard.maw@gmail.com>
2016-07-12git: update to v2.9.1Christian Hesse2-1/+1
Update to git version v2.9.1, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-07-06Link with -ldl on GNU/kFreeBSDPeter Colberg1-2/+2
GNU/kFreeBSD uses the FreeBSD kernel with the GNU C library. Signed-off-by: Peter Colberg <peter@colberg.org>
2016-07-06Fix spelling in man pagePeter Colberg1-2/+2
Signed-off-by: Peter Colberg <peter@colberg.org>
2016-07-06ui-shared: fix segfault when defbranch is NULLEric Wong1-1/+1
Not sure if there's a better fix for this. defbranch is NULL here on my setup when a crawler hit an invalid URL, causing strcmp to segfault. Signed-off-by: Eric Wong <normalperson@yhbt.net>
2016-07-05css: consistent use of empty linesChristian Hesse1-0/+6
Signed-off-by: Christian Hesse <mail@eworm.de>
2016-07-05ui-log: color line changesChristian Hesse2-1/+11
Signed-off-by: Christian Hesse <mail@eworm.de>
2016-07-05Avoid ambiguities when prettifying snapshot namesLukas Fleischer3-20/+32
When composing snapshot file names for a tag with a prefix of the form v[0-9] (resp. V[0-9]), the leading "v" (resp. "V") is stripped. This leads to conflicts if a tag with the stripped name already exists or if there are tags only differing in the capitalization of the leading "v". Make sure we do not strip the "v" in these cases. Reported-by: Juuso Lapinlampi <wub@partyvan.eu> Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
2016-06-17git: update to v2.9.0Christian Hesse2-1/+1
Update to git version v2.9.0, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-06-17cgit.mk: Use $PKG_CONFIGKylie McClain1-3/+5
PKG_CONFIG is a variable dictated by autoconf standards; it should be used if set.
2016-06-17md2html: use utf-8 and flush output bufferJason A. Donenfeld1-6/+11
Otherwise we get the classic Python UTF-8 errors, and the text is all out of order. While we're at it, switch to python3 so we only have to support one set of oddball semantics. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Suggested-by: Daniel Campbell <dlcampbell@gmx.com>
2016-06-07Hosted on HTTPS nowJason A. Donenfeld4-5/+5
2016-06-07Bump version.v1.0Jason A. Donenfeld1-1/+1
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-05-20git: update to v2.8.3Christian Hesse2-1/+1
Update to git version v2.8.3, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-05-12ui-diff: action='.' is not correctJason A. Donenfeld1-1/+1
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-05-12forms: action should not be emptyJason A. Donenfeld2-2/+2
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-05-12ui-shared: Remove a name attribute with an empty valueJuuso Lapinlampi1-1/+1
The name attribute is optional in an input element, but it must not be an empty value. See: https://html.spec.whatwg.org/#attr-fe-name See: https://html.spec.whatwg.org/#the-input-element
2016-05-12ui-shared: HTML-ize DOCTYPE and <html>Juuso Lapinlampi1-3/+2
Get rid of the XHTML headers, bringing cgit slowly to the modern age of HTML.
2016-05-12ui-shared: Simplify cgit_print_error_page() logicJuuso Lapinlampi1-4/+2
2016-05-12git: update to v2.8.2Christian Hesse3-2/+2
Update to git version v2.8.2. * Upstream commit 1a0c8dfd89475d6bb09ddee8c019cf0ae5b3bdc2 (strbuf: give strbuf_getline() to the "most text friendly" variant) changed API. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-05-12ui-log: Simplify decoration codeTim Nordell1-24/+22
The decoration code inside of git returns the decoration type, so utilize this to create the decoration spans. Additionally, use prettify_refname(...) to get the shorter name for the ref. Signed-off-by: Tim Nordell <tim.nordell@logicpd.com>
2016-05-12ui-log: Do not always emit decoration spanTim Nordell1-0/+2
The decoration span does not need to be emited if there aren't any decorations to show. This modification saves slightly on bandwidth. Signed-off-by: Tim Nordell <tim.nordell@logicpd.com>
2016-03-08Renamed repo-specific configuration for enable-html-serving in cgitrc.5.txtMatt Comben1-1/+1
2016-02-26ui-shared: redirect should not exit early for cacheJason A. Donenfeld1-1/+0
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-02-26about: path_info might not be validJason A. Donenfeld1-1/+2
2016-02-23tabs: do not use target=_blankJason A. Donenfeld1-1/+1
2016-02-23css: fix indentationJason A. Donenfeld1-4/+4
2016-02-23css: use less blurry icon for external linkChristian Hesse1-1/+2
Your mileage may vary, but for me the old icon looks blurry. The new one is character 0xf08e from OTF font awsome in size 10. The icon color is black, gray level is adjusted via opacity. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-02-23md2html: Do syntax highlighting tooJason A. Donenfeld1-1/+5
2016-02-23git: update to v2.7.2Christian Hesse2-1/+1
Update to git version v2.7.2, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-02-22ui-plain: fix to show a repo's root directory listing in plain viewJoe Anakata1-1/+1
This is to fix the case of accessing http://host.com/cgit.cgi/repo.git/plain/ There is code here to make this case work (match_baselen is set to -1 for top-of-the-tree views) but the unsigned to signed comparison was always false in this case, causing an empty directory listing without this fix. Signed-off-by: Joe Anakata <jea-signup-github@anakata.org> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-02-22cmd: redirect empty about/ to homepage or summaryJason A. Donenfeld1-1/+10
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-02-22ui-shared: add homepage to tabsJason A. Donenfeld7-5/+26
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2016-02-08ui-atom: avoid DATE_STRFTIMEJohn Keeping2-12/+4
Git's DATE_STRFTIME ignores the timezone argument and just uses the local timezone regardless of whether the "local" flag is set. Since Atom accepts ISO8601 dates [1], we can use Git's DATE_ISO8601_STRICT instead, which does get this right. Additionally, we never use the local timezone here so we can use the date_mode_from_type() wrapper to simplify the code a bit. [1] https://tools.ietf.org/html/rfc4287#section-3.3 Signed-off-by: John Keeping <john@keeping.me.uk>
2016-02-08Avoid DATE_STRFTIME for long/short datesJohn Keeping5-13/+10
Git's DATE_STRFTIME ignores the timezone argument and just uses the local timezone regardless of whether the "local" flag is set. Since our existing FMT_LONGDATE and FMT_SHORTDATE are pretty-much perfect matches to DATE_ISO8601 and DATE_SHORT, switch to taking a date_mode_type directly in cgit_date_mode(). Signed-off-by: John Keeping <john@keeping.me.uk>
2016-02-08ui-stats: cast pointer before checking for zeroJohn Keeping1-2/+2
We abuse the "void *util" field as a counter and recently started to cast it to a uintptr_t to avoid risking nasal demons by performing arithmetic on a void pointer. However, compilers are also known to do "interesting" things if they know that a pointer is or isn't NULL. Make this safer by checking if the counter (after casting) is non-zero rather than checking if the pointer is non-null. Signed-off-by: John Keeping <john@keeping.me.uk>
2016-02-08ui-stats: if we're going to abuse void*, do it safelyJason A. Donenfeld1-10/+7
2016-02-08git: update to v2.7.1Christian Hesse2-1/+1
Update to git version v2.7.1, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2016-02-08ui-shared: remove cgit_print_date()John Keeping2-21/+0
There are no longer any users of this function. Signed-off-by: John Keeping <john@keeping.me.uk>
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.