From 481ce5e298e2dcd7edc1d4a30e523dda2ce58b01 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sun, 1 Feb 2009 19:29:24 +0100 Subject: shared.c: avoid SEGFAULT when checking for binary buffers Before calling buffer_is_binary() we need to verify that the buffer is valid. Signed-off-by: Lars Hjemli --- shared.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shared.c b/shared.c index dbb84d8..cce0af4 100644 --- a/shared.c +++ b/shared.c @@ -271,8 +271,8 @@ int cgit_diff_files(const unsigned char *old_sha1, *old_size = file1.size; *new_size = file2.size; - if (buffer_is_binary(file1.ptr, file1.size) || - buffer_is_binary(file2.ptr, file2.size)) { + if ((file1.ptr && buffer_is_binary(file1.ptr, file1.size)) || + (file2.ptr && buffer_is_binary(file2.ptr, file2.size))) { *binary = 1; return 0; } -- cgit v1.2.3-59-g8ed1b