From 892c5441f4af2f53a3b1906c4d7e458829e0cf0a Mon Sep 17 00:00:00 2001 From: John Keeping Date: Fri, 14 Aug 2015 12:47:17 +0100 Subject: stats: move layout into page function This also allows us to return proper HTTP error codes for invalid requests. Signed-off-by: John Keeping --- ui-stats.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'ui-stats.c') diff --git a/ui-stats.c b/ui-stats.c index 9cd8247..74ce0f7 100644 --- a/ui-stats.c +++ b/ui-stats.c @@ -372,11 +372,13 @@ void cgit_show_stats(void) i = cgit_find_stats_period(code, &period); if (!i) { - cgit_print_error("Unknown statistics type: %c", code[0]); + cgit_print_error_page(404, "Not found", + "Unknown statistics type: %c", code[0]); return; } if (i > ctx.repo->max_stats) { - cgit_print_error("Statistics type disabled: %s", period->name); + cgit_print_error_page(400, "Bad request", + "Statistics type disabled: %s", period->name); return; } authors = collect_stats(period); @@ -387,6 +389,7 @@ void cgit_show_stats(void) if (!top) top = 10; + cgit_print_layout_start(); html("
"); html("stat options"); html("
"); @@ -421,5 +424,6 @@ void cgit_show_stats(void) } html(""); print_authors(&authors, top, period); + cgit_print_layout_end(); } -- cgit v1.2.3-59-g8ed1b