diff options
| author |   Roland Hieber <rhi@pengutronix.de> | 2024-04-25 12:18:42 +0200 |
|---|---|---|
| committer |   Junio C Hamano <gitster@pobox.com> | 2024-04-25 09:23:26 -0700 |
| commit | cb85fdf4a4445fd201133dfc8d1e43c7e2e68bf5 (patch) | |
| tree | 2958e0a993f66591aa8d2b61aac3c33cf0029cf0 | |
| parent | Git 2.44 (diff) | |
| download | git-cb85fdf4a4445fd201133dfc8d1e43c7e2e68bf5.tar.xz git-cb85fdf4a4445fd201133dfc8d1e43c7e2e68bf5.zip | |
completion: add 'symbolic-ref'
Even 'symbolic-ref' is only completed when
GIT_COMPLETION_SHOW_ALL_COMMANDS=1 is set, it currently defaults to
completing file names, which is not very helpful. Add a simple
completion function which completes options and refs.
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | contrib/completion/git-completion.bash | 11 | ||||
| -rwxr-xr-x | t/t9902-completion.sh | 23 |
2 files changed, 34 insertions, 0 deletions
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 444b3efa630..25c2eb69779 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -3523,6 +3523,17 @@ _git_svn () fi } +_git_symbolic_ref () { + case "$cur" in + --*) + __gitcomp_builtin symbolic-ref + return + ;; + esac + + __git_complete_refs +} + _git_tag () { local i c="$__git_cmd_idx" f=0 diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index b16c284181b..7773de3469f 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -2495,6 +2495,29 @@ test_expect_success 'complete tree filename with metacharacters' ' EOF ' +test_expect_success 'symbolic-ref completes builtin options' ' + test_completion "git symbolic-ref --d" <<-\EOF + --delete Z + EOF +' + +test_expect_success 'symbolic-ref completes short ref names' ' + test_completion "git symbolic-ref foo m" <<-\EOF + main Z + mybranch Z + mytag Z + EOF +' + +test_expect_success 'symbolic-ref completes full ref names' ' + test_completion "git symbolic-ref foo refs/" <<-\EOF + refs/heads/main Z + refs/heads/mybranch Z + refs/tags/mytag Z + refs/tags/A Z + EOF +' + test_expect_success PERL 'send-email' ' test_completion "git send-email --cov" <<-\EOF && --cover-from-description=Z |