glibc/iconv, branch master

Update copyright dates not handled by scripts/update-copyrights

2024-01-01T18:53:40Z

I've updated copyright dates in glibc for 2024. This is the patch for the changes not generated by scripts/update-copyrights and subsequent build / regeneration of generated files.

Update copyright dates with scripts/update-copyrights

2024-01-01T18:53:40Z

Fix off-by-one OOB write in iconv/tst-iconv-mt

2023-10-04T07:33:20Z

The iconv buffer sizes must not include the \0 string terminator. And the output termination with *outbufpos = '\0' was OOB. Consistently use non-null-terminated buffer sizes. Reviewed-by: Adhemerval Zanella

iconv: restore verbosity with unrecognized encoding names (bug 30694)

2023-08-02T11:30:04Z

Commit 91927b7c76 ("Rewrite iconv option parsing [BZ #19519]") changed the iconv program to call __gconv_open directly instead of the iconv_open wrapper, but the former does not set errno. Update the caller to interpret the return codes like iconv_open does.

Fix misspellings in iconv/ and iconvdata/ -- BZ 25337

2023-05-27T16:37:14Z

All the changes are in comments or '#error' messages. Applying this commit results in bit-identical rebuild of iconvdata/*.so Reviewed-by: Florian Weimer

Use O_CLOEXEC in more places (BZ #15722)

2023-04-22T11:50:14Z

When opening a temporary file without O_CLOEXEC we risk leaking the file descriptor if another thread calls (fork and then) exec while we have the fd open. Fix this by consistently passing O_CLOEXEC everywhere where we open a file for internal use (and not to return it to the user, in which case the API defines whether or not the close-on-exec flag shall be set on the returned fd). Reviewed-by: Adhemerval Zanella Signed-off-by: Sergey Bugaev Message-Id: <20230419160207.65988-4-bugaevc@gmail.com>

Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions

2023-03-27T16:57:55Z

They are both used by __libc_freeres to free all library malloc allocated resources to help tooling like mtrace or valgrind with memory leak tracking. The current scheme uses assembly markers and linker script entries to consolidate the free routine function pointers in the RELRO segment and to be freed buffers in BSS. This patch changes it to use specific free functions for libc_freeres_ptrs buffers and call the function pointer array directly with call_function_static_weak. It allows the removal of both the internal macros and the linker script sections. Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. Reviewed-by: Carlos O'Donell

iconv: Remove _STRING_ARCH_unaligned usage

2023-02-17T18:56:54Z

Use put/get macros __builtin_bswap32 instead. It allows to remove the unaligned routines, the compiler will generate unaligned access if the ABI allows it. Checked on x86_64-linux-gnu and i686-linux-gnu. Reviewed-by: Wilco Dijkstra

iconv: Remove _STRING_ARCH_unaligned usage for get/set macros

2023-02-17T18:56:54Z

And use a packed structure instead. The compiler generates optimized unaligned code if the architecture supports it. Checked on x86_64-linux-gnu and i686-linux-gnu. Reviewed-by: Wilco Dijkstra

Replace rawmemchr (s, '\0') with strchr

2023-02-06T16:16:19Z

Almost all uses of rawmemchr find the end of a string. Since most targets use a generic implementation, replacing it with strchr is better since that is optimized by compilers into strlen (s) + s. Also fix the generic rawmemchr implementation to use a cast to unsigned char in the if statement. Reviewed-by: Adhemerval Zanella