glibc/libio, branch master

libio: handle opening a file when all files are closed (bug 31963)

2024-07-09T08:12:36Z

_IO_list_all becomes NULL when all files (including standard files) are closed.

Fix conditionals on mtrace-based tests (bug 31892)

2024-07-01T15:20:30Z

The conditionals for several mtrace-based tests in catgets, elf, libio, malloc, misc, nptl, posix, and stdio-common were incorrect leading to test failures when bootstrapping glibc without perl. The correct conditional for mtrace-based tests requires three checks: first checking for run-built-tests, then build-shared, and lastly that PERL is not equal to "no" (missing perl). Reviewed-by: Adhemerval Zanella

: Acknowledge that getdelim/getline are in POSIX

2024-06-11T21:17:12Z

These comments were written in 2003 (added in 2c008571c3a), predating the addition of getdelim(3)/getline(3) in POSIX.1-2008. Reviewed-by: Sam James Reviewed-by: Florian Weimer

libio: Test for fdopen memory leak without SEEK_END support (bug 31840)

2024-06-04T14:09:33Z

The bug report used /dev/mem, but /proc/self/mem works as well (if available).

Remove memory leak in fdopen (bug 31840)

2024-06-04T12:42:06Z

Deallocate the memory for the FILE structure when seeking to the end fails in append mode. Fixes: ea33158c96 ("Fix offset caching for streams and use it for ftell (BZ #16680)")

Change _IO_stderr_/_IO_stdin_/_IO_stdout to compat symbols [BZ #31766]

2024-05-21T17:12:25Z

Since Glibc never provides symbol binary compatibility for relocatable files, fix BZ #31766 by changing _IO_stderr_/_IO_stdin_/_IO_stdout to compat symbols. Signed-off-by: H.J. Lu Reviewed-by: Sunil K Pandey

Use a doubly-linked list for _IO_list_all (bug 27777)

2024-05-17T21:13:25Z

This patch fixes BZ #27777 "fclose does a linear search, takes ages when many FILE* are opened". Simply put, the master list of opened (FILE*), namely _IO_list_all, is a singly-linked list. As a consequence, the removal of a single element is in O(N), which cripples the performance of fclose(). The patch switches to a doubly-linked list, yielding O(1) removal. The one padding field in struct _IO_FILE, __pad5, is renamed to _prevchain for a doubly-linked list. Since fields in struct _IO_FILE after the _lock field are internal to glibc and opaque to applications. We can change them as long as the size of struct _IO_FILE is unchanged, which is checked as the part of glibc ABI with sizes of _IO_2_1_stdin_, _IO_2_1_stdout_ and _IO_2_1_stderr_. NB: When _IO_vtable_offset (fp) == 0, copy relocation will cover the whole struct _IO_FILE. Otherwise, only fields up to the _lock field will be copied to applications at run-time. It is used to check if the _prevchain field can be safely accessed. After opening 2 million (FILE*), the fclose() of 100 of them takes quite a few seconds without the patch, and under 2 seconds with it on a loaded machine. No test is added since there are no functional changes. Co-Authored-By: H.J. Lu Signed-off-by: Alexandre Ferrieux Signed-off-by: H.J. Lu Reviewed-by: Carlos O'Donell

libio/bug-wsetpos: Make the error message match the causing function

2024-05-13T11:50:48Z

This test case calls `fopen': FILE *fp = fopen (temp_file, "r"); however if that fails it reports `fdopen' being the origin of the error. Adjust the message to say `fopen' then.

Add crt1-2.0.o for glibc 2.0 compatibility tests

2024-05-06T14:49:40Z

Starting from glibc 2.1, crt1.o contains _IO_stdin_used which is checked by _IO_check_libio to provide binary compatibility for glibc 2.0. Add crt1-2.0.o for tests against glibc 2.0. Define tests-2.0 for glibc 2.0 compatibility tests. Add and update glibc 2.0 compatibility tests for stderr, matherr and pthread_kill. Reviewed-by: Carlos O'Donell

libio: Sort test variables in Makefile

2024-04-30T16:43:20Z

Sort test variables in libio/Makefile using scripts/sort-makefile-lines.py. Reviewed-by: Sunil K Pandey