diff options
author | Philipp Maier <pmaier@sysmocom.de> | 2021-05-20 21:01:23 +0200 |
---|---|---|
committer | Philipp Maier <pmaier@sysmocom.de> | 2021-05-20 21:11:50 +0200 |
commit | ea0f1bd49e730aa17e48d4946414d66cfa24beb3 (patch) | |
tree | 2cbad7883acb5e5f8a7df98d8508f50feb204b21 | |
parent | Fix up vty 'show' commands for E1 line/timeslots (diff) | |
download | libosmo-abis-ea0f1bd49e730aa17e48d4946414d66cfa24beb3.tar.xz libosmo-abis-ea0f1bd49e730aa17e48d4946414d66cfa24beb3.zip |
ipaccess: do not block ipaccess_line_update on failure
The function ipaccess_line_update (called when the API user calls
e1inp_line_update and the line is of type ipaccess) internally sets
the line_already_initialized regardless whether the initalization is
successful or not.
This also means that if the initalization fails the API user is unable
to retry the initalition with corrected line options.
Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d
Related: SYS#4971
-rw-r--r-- | src/input/ipaccess.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index e876790..a584e0d 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1025,8 +1025,6 @@ static int ipaccess_line_update(struct e1inp_line *line) if (il->line_already_initialized) return 0; - il->line_already_initialized = true; - switch(line->ops->cfg.ipa.role) { case E1INP_LINE_R_BSC: { struct ipa_server_link *oml_link, *rsl_link; @@ -1112,6 +1110,8 @@ static int ipaccess_line_update(struct e1inp_line *line) default: break; } + + il->line_already_initialized = true; return ret; } |