linux-dev/drivers/auxdisplay, branch linus/master

auxdisplay: lcd2s: Use array size explicitly in lcd2s_gotoxy()

2022-03-18T19:31:14Z

Currently the reading of the onstack array is confusing since two out of three members are of different types. Let it be more clear by explicitly set the array size, so everybody will understand that parameters are cast to the type of the array. While at it, add a missed space. Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Switch to i2c ->probe_new()

2022-03-18T19:31:14Z

The deprecated i2c ->probe() functionality doesn't work with OF compatible strings, as it only checks for the i2c device id. While it's not a problem right now, it would still bring a better code. Switch to the new way of probing. Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: use module_i2c_driver to simplify the code

2022-03-18T19:31:14Z

Use the module_i2c_driver() macro to make the code smaller and a bit simpler. Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: make use of device property API

2022-03-18T19:31:14Z

Make use of device property API in this driver so that both OF based system and ACPI based system can use this driver. Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Fix multi-line comment style

2022-03-18T19:31:02Z

Fix multi-line comment style: - start sentences with Capital letter - use non-networking style of the first line Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

2022-03-02T23:30:31Z

While it might work, the current approach is fragile in a few ways: - whenever members in the structure are shuffled, the pointer will be wrong - the resource freeing may include more than covered by kfree() Fix this by using charlcd_free() call instead of kfree(). Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") Cc: Lars Poeschel Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Fix memory leak in ->remove()

2022-03-02T23:30:14Z

Once allocated the struct lcd2s_data is never freed. Fix the memory leak by switching to devm_kzalloc(). Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") Cc: Lars Poeschel Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature

2022-03-02T23:29:26Z

It seems that the lcd2s_redefine_char() has never been properly tested. The buffer is filled by DEF_CUSTOM_CHAR command followed by the character number (from 0 to 7), but immediately after that these bytes are rewritten by the decoded hex stream. Fix the index to fill the buffer after the command and number. Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") Cc: Lars Poeschel Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven [fixed typo in commit message] Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: checking for pointer reference before dereferencing

2021-11-24T10:46:52Z

Check if the pointer lcd->ops->init_display exists before dereferencing it. If a driver called charlcd_init() without defining the ops, this would return segmentation fault, as happened to me when implementing a charlcd driver. Checking the pointer before dereferencing protects from segmentation fault. Signed-off-by: Luiz Sampaio Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fixing coding style issue

2021-11-24T10:46:42Z

Removing 'int' from 'unsigned long int' declaration, which is unnecessary. Signed-off-by: Luiz Sampaio Signed-off-by: Miguel Ojeda