linux-dev/drivers/char/ipmi, branch linus/master

ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe

2022-05-12T15:00:04Z

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 00d93611f002 ("ipmi:ipmb: Add the ability to have a separate slave and master device") Signed-off-by: Miaoqian Lin Message-Id: <20220512044445.3102-1-linmq006@gmail.com> Cc: stable@vger.kernel.org # v5.17+ Signed-off-by: Corey Minyard

ipmi: remove unnecessary type castings

2022-05-12T15:00:04Z

remove unnecessary void* type castings. Signed-off-by: Yu Zhe Message-Id: <20220421150941.7659-1-yuzhe@nfschina.com> Signed-off-by: Corey Minyard

ipmi: Make two logs unique

2022-05-12T15:00:04Z

There were two identical logs in two different places, so you couldn't tell which one was being logged. Make them unique. Signed-off-by: Corey Minyard

ipmi:si: Convert pr_debug() to dev_dbg()

2022-05-12T15:00:04Z

A device is available, use it. Signed-off-by: Corey Minyard

ipmi: Convert pr_debug() to dev_dbg()

2022-05-12T15:00:04Z

A device is available at all debug points, use the right interface. Signed-off-by: Corey Minyard

ipmi: Fix pr_fmt to avoid compilation issues

2022-05-12T15:00:04Z

The was it was wouldn't work in some situations, simplify it. What was there was unnecessary complexity. Reported-by: kernel test robot Signed-off-by: Corey Minyard

ipmi: Add an intializer for ipmi_recv_msg struct

2022-05-12T15:00:03Z

Don't hand-initialize the struct here, create a macro to initialize it so new fields added don't get forgotten in places. Signed-off-by: Corey Minyard

ipmi: Add an intializer for ipmi_smi_msg struct

2022-05-12T15:00:03Z

There was a "type" element added to this structure, but some static values were missed. The default value will be zero, which is correct, but create an initializer for the type and initialize the type properly in the initializer to avoid future issues. Reported-by: Joe Wiese Signed-off-by: Corey Minyard

ipmi:ssif: Check for NULL msg when handling events and messages

2022-05-12T15:00:03Z

Even though it's not possible to get into the SSIF_GETTING_MESSAGES and SSIF_GETTING_EVENTS states without a valid message in the msg field, it's probably best to be defensive here and check and print a log, since that means something else went wrong. Also add a default clause to that switch statement to release the lock and print a log, in case the state variable gets messed up somehow. Reported-by: Haowen Bai Signed-off-by: Corey Minyard

ipmi: use simple i2c probe function

2022-05-12T15:00:03Z

The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt Message-Id: <20220324171159.544565-1-steve@sk2.org> Signed-off-by: Corey Minyard Reviewed-by: Wolfram Sang