linux-dev/drivers/hid/i2c-hid, branch linus/master

Merge branch 'for-5.18/i2c-hid' into for-linus

2022-03-23T09:04:40Z

- fixes for handling unnumbered reports fully correctly (Angela Czubak Dmitry Torokhov) - untangling of intermingled code for sending and handling output reports in __i2c_hid_command() (Dmitry Torokhov)

HID: i2c-hid: remove unneeded semicolon

2022-02-16T15:30:00Z

Eliminate the following coccicheck warning: ./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li Signed-off-by: Jiri Kosina

HID: i2c-hid: note that I2C xfer buffers are DMA-safe

2022-02-14T09:52:29Z

All I2C communications in the driver use driver-private buffers that are DMA-safe, so mark them as such. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: no longer need raw access to HID descriptor structure

2022-02-14T09:52:29Z

We can stop defining a union for HID descriptor data as we now only access individual members of it by names and using proper types instead of accessing by offset from the beginning of the data structure. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: use helpers to do endian conversion in i2c_hid_get_input()

2022-02-14T09:52:29Z

It is better to use helpers to do endian conversion as it documents and draws attention to it, and might be a bit more performant as well. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: rework i2c_hid_get_report() to use i2c_hid_xfer()

2022-02-14T09:51:08Z

Explicitly prepare command for i2c_hid_get_report() which makes the logic clearer and allows us to get rid of __i2c_hid_command() and related command definitions. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: convert i2c_hid_execute_reset() to use i2c_hid_xfer()

2022-02-14T09:51:08Z

This will allow us to drop i2c_hid_command() wrapper and get close to removing __i2c_hid_command(). Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: create a helper for SET_POWER command

2022-02-14T09:51:08Z

Another case where creating a dedicated helper allows for cleaner code that shows exactly what communication happens with the device when toggling its power. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: define i2c_hid_read_register() and use it

2022-02-14T09:51:07Z

Handling simple read of device registers in __i2c_hid_command() makes it too complicated and the need of special handling for the HID descriptor register adds even more complexity. Instead, let's create simple i2c_hid_read_register() helper on base of i2c_hid_xfer() and use it. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: i2c-hid: explicitly code setting and sending reports

2022-02-14T09:51:07Z

Instead of relying on __i2c_hid_command() that tries to handle all commands and because of that is very complicated, let's define a new dumb helper i2c_hid_xfer() that actually transfers (write and read) data, and use it when sending and setting reports. By doing that we can save on number of copy operations we have to execute, and make logic of sending reports much clearer. Signed-off-by: Dmitry Torokhov Tested-by: Benjamin Tissoires Signed-off-by: Jiri Kosina