linux-dev/drivers/i3c/master, branch master

i3c: master: svc: fix returnvar.cocci warning

2022-05-17T20:34:42Z

Fix the following coccicheck warning: drivers/i3c/master/svc-i3c-master.c:1600:5-8: Unneeded variable: "ret". Return "0" on line 1605. Signed-off-by: Guo Zhengkui Reviewed-by: Miquel Raynal Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220504164901.9622-1-guozhengkui@vivo.com

i3c/master: simplify the return expression of i3c_hci_remove()

2022-05-17T20:33:43Z

Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220505021954.54524-1-chi.minghao@zte.com.cn

i3c: master: dw: check return of dw_i3c_master_get_free_pos()

2022-01-13T01:05:50Z

Clang static analysis reports this problem dw-i3c-master.c:799:9: warning: The result of the left shift is undefined because the left operand is negative COMMAND_PORT_DEV_INDEX(pos) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ pos can be negative because dw_i3c_master_get_free_pos() can return an error. So check for an error. Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP") Signed-off-by: Tom Rix Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com

i3c: master: mipi-i3c-hci: correct the config reference for endianness

2022-01-05T08:54:54Z

The referred config BIG_ENDIAN does not exist. The config for the endianness of the CPU architecture is called CPU_BIG_ENDIAN. Correct the config name to the existing config for the endianness. Signed-off-by: Lukas Bulwahn Acked-by: Nicolas Pitre Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220103094504.3602-1-lukas.bulwahn@gmail.com

i3c: master: svc: enable the interrupt in the enable ibi function

2022-01-05T08:53:44Z

If enable interrupt in the svc_i3c_master_bus_init() but do not call enable ibi in the device driver, it will cause a kernel dump in the svc_i3c_master_handle_ibi() when a slave start occurs on the i3c bus, because the data->ibi_pool is not initialized. So only enable the interrupt in svc_i3c_master_enable_ibi() function. Signed-off-by: Clark Wang Reviewed-by: Miquel Raynal Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-9-xiaoning.wang@nxp.com

i3c: master: svc: add the missing module device table

2022-01-05T08:53:44Z

The missing MODULE_DEVICE_TABLE() will cause the svc-i3c-master cannot be auto probed when it is built in moudle. So add it. Signed-off-by: Clark Wang Reviewed-by: Miquel Raynal Reviewed-by: Jun Li Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-8-xiaoning.wang@nxp.com

i3c: master: svc: add runtime pm support

2022-01-05T08:53:44Z

Add runtime pm support to dynamically manage the clock. Signed-off-by: Clark Wang Reviewed-by: Miquel Raynal Reviewed-by: Jun Li Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-7-xiaoning.wang@nxp.com

i3c: master: svc: set ODSTOP to let I2C device see the STOP signal

2022-01-05T08:53:44Z

If using I2C/I3C mixed mode, need to set ODSTOP. Otherwise, the I2C devices cannot see the stop signal. It may cause message sending errors. Signed-off-by: Clark Wang Reviewed-by: Miquel Raynal Reviewed-by: Jun Li Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-6-xiaoning.wang@nxp.com

i3c: master: svc: add support for slave to stop returning data

2022-01-05T08:53:44Z

When i3c controller reads data from slave device, slave device can stop returning data with an ACK after any byte. Add this support for svc i3c controller. Otherwise, it will timeout when the slave device ends the read operation early. Signed-off-by: Clark Wang Reviewed-by: Jun Li Reviewed-by: Miquel Raynal Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-5-xiaoning.wang@nxp.com

i3c: master: svc: separate err, fifo and disable interrupt of reset function

2022-01-05T08:53:44Z

Sometimes only need to reset err and fifo regs, so split the origin reset function to three functions. Put them at the top of the file, to let more functions can call them. Signed-off-by: Clark Wang Reviewed-by: Miquel Raynal Reviewed-by: Jun Li Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211227074529.1660398-4-xiaoning.wang@nxp.com