linux-dev/drivers/media/i2c/max2175.c, branch linus/master

media: i2c: max2175: Use rbtree rather than flat register cache

2022-03-07T16:21:53Z

The max2175 uses a flat register cache but supplies only a single default value and has many volatile registers. This is a poor fit for a flat cache since the cache will assume a default of zero for any register not yet written which can lead to bugs for example when regmap_update_bits() suppresses a noop write. A rbtree cache is a much better fit, this will only cache default values and values that have been written to the device with any reads of uncached values going to the hardware. Convert the driver to use a rbtree cache. Since the device is controlled via I2C the cost of manging the rbtree should be immaterial compared to the cost of accessing the device. Signed-off-by: Mark Brown Signed-off-by: Hans Verkuil

media: media/i2c: remove unneeded variable: "ret"

2021-03-11T10:59:43Z

remove unneeded variable: "ret" Signed-off-by: zuoqilin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: max2175: fix max2175_set_csm_mode() error code

2020-11-27T09:58:30Z

This is supposed to return negative error codes but the type is bool so it returns true instead. Fixes: b47b79d8a231 ("[media] media: i2c: max2175: Add MAX2175 support") Signed-off-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab

media: docs: add an uAPI chapter for driver-specific stuff

2020-04-14T08:36:50Z

There are some uAPI stuff that are driver-specific. Add them to the main media uAPI body. Signed-off-by: Mauro Carvalho Chehab

media: i2c: Use div64_ul() for u64-by-unsigned-long divide

2019-10-10T10:15:57Z

div_u64() does a 64-by-32 division, while the divisor max2175.xtal_freq is unsigned long, thus 64-bit on 64-bit platforms. Hence the proper function to call is div64_ul(). Note that this change does not have any functional impact, as the crystal frequency must be much lower than the 32-bit limit anyway. On 32-bit platforms, the generated code is the same. But at least on arm64, this saves an AND-instruction to truncate xtal_freq to 32-bit. Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: i2c: Convert to new i2c device probe()

2019-08-13T14:54:04Z

The I2C core framework provides a simplified probe framework from commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"). These drivers do not utilise the i2c_device_id table in the probe, so we can easily convert them to utilise the simplified i2c driver registration. Signed-off-by: Kieran Bingham Acked-by: Andrzej Hajda Reviewed-by: Wolfram Sang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: i2c: max2175: convert to SPDX identifiers

2018-09-12T14:51:18Z

This patch updates license to use SPDX-License-Identifier instead of verbose license text. Signed-off-by: Kuninori Morimoto Acked-by: Ramesh Shanmugasundaram Signed-off-by: Mauro Carvalho Chehab

media: use strscpy() instead of strlcpy()

2018-09-11T17:32:17Z

The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Kees Cook Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: max2175: fix location of driver's companion documentation

2018-06-15T21:10:41Z

There's a missing ".rst" at the doc's file name. Acked-by: Ramesh Shanmugasundaram Signed-off-by: Mauro Carvalho Chehab Acked-by: Jonathan Corbet

media: i2c: max2175: use 64-bit arithmetic instead of 32-bit

2018-02-26T13:08:15Z

Add suffix LL to constant 2 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type s64 (64 bits, signed). The expression 2 * (clock_rate - abs_nco_freq) is currently being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 1446589 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab