linux-dev/drivers/net/arcnet/com20020.c, branch linus/master

net: remove single-byte netdev->dev_addr writes

2021-10-13T17:03:59Z

Make the drivers which use single-byte netdev addresses (netdev->addr_len == 1) use the appropriate address setting helpers. arcnet copies from int variables and io reads a lot, so add a helper for arcnet drivers to use. Similar helper could be reused for phonet and appletalk but there isn't any good central location where we could put it, and netdevice.h is already very crowded. Acked-by: Sebastian Reichel # for HSI Link: https://lore.kernel.org/r/20211012142757.4124842-1-kuba@kernel.org Signed-off-by: Jakub Kicinski

arcnet: com20020: remove needless base_addr assignment

2017-06-29T19:18:36Z

The assignment is superfluous. Signed-off-by: Michael Grzeschik Signed-off-by: David S. Miller

arcnet: com20020: add enable and disable device on open/close

2015-10-26T08:10:56Z

This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

arcnet: com20020: replace magic numbers with readable macros

2015-09-23T06:44:28Z

This patch replaces all magic numbers in the driver with proper named macros. For the case of XTOcfg and STARTIOcmd it introduces the new macros. Signed-off-by: Michael Grzeschik

arcnet: com20020: Use arcnet_ routines

2015-09-23T06:44:26Z
Simplify and make consistent the current uses of inb/outb by using the newly introduced arcnet_ equivalents. o Add new #defines for register offsets There is an register offset, 8, that is unnamed and used as-is. o Remove old #defines that included the ioaddr o Remove obfuscating macros by expanding them in-place where appropriate o Create static inline com20020_set_subaddress for the SET_SUBADR macro There is an unused arcnet config entry CONFIGSA100_CT6001 which added a special #define BUS_ALIGN which was introduced but never used in fullhist git tree commit 22cfce4b82b0 ("[ARCNET]: Fixes.") in Nov 2004 for Linux v2.6.10. This BUS_ALIGN #define tries to allow 8 bit devices to work on a 16 bit bus by aligning addresses to 16 bit boundaries. Move this currently unused CONFIG_SA1100_CT6001 BUS_ALIGN macro from com20020.h to arcdevice.h. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik

arcnet: Make a char * array const char * const

2015-09-23T06:44:26Z
Might as well be specific about the use of this array. Add a commment questioning the indexing too. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik

arcnet: Move files out of include/linux

2015-09-23T06:44:25Z
These #include files don't need to be in the include/linux directory as they can be local to drivers/net/arcnet/ Move them and update the #include statements. Update the MAINTAINERS file pattern by deleting arcdevice from the NETWORKING block as arcnet is currently unmaintained. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik

arcnet: Wrap some long lines

2015-09-23T06:44:25Z
Just neatening. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik

arcnet: Remove assignments from ifs

2015-09-23T06:44:25Z
Move the assignment above the if like general kernel style. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik

arcnet: Convert printk to pr_

2015-09-23T06:44:24Z
Use the more current logging style. Remove #define VERSION, use pr_info normally. Add pr_fmt with "arcnet:" prefixes and KBUILD_MODNAME. Signed-off-by: Joe Perches Signed-off-by: Michael Grzeschik