linux-dev/drivers/net/ethernet/sun, branch master

sunhme: Uninitialized variable in happy_meal_init()

2022-10-15T10:14:24Z

The "burst" string is only initialized for CONFIG_SPARC. It should be set to "64" because that's what is used by PCI. Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages") Signed-off-by: Dan Carpenter Reviewed-by: Sean Anderson Signed-off-by: David S. Miller

sunhme: fix an IS_ERR() vs NULL check in probe

2022-10-13T16:34:09Z

The devm_request_region() function does not return error pointers, it returns NULL on error. Fixes: 914d9b2711dd ("sunhme: switch to devres") Signed-off-by: Dan Carpenter Reviewed-by: Sean Anderson Reviewed-by: Rolf Eike Beer Link: https://lore.kernel.org/r/Y0bWzJL8JknX8MUf@kili Signed-off-by: Jakub Kicinski

net: sunhme: Fix undersized zeroing of quattro->happy_meals

2022-09-29T02:18:42Z

Just use kzalloc instead. Fixes: d6f1e89bdbb8 ("sunhme: Return an ERR_PTR from quattro_pci_find") Reported-by: kernel test robot Signed-off-by: Sean Anderson Link: https://lore.kernel.org/r/20220928004157.279731-1-seanga2@gmail.com Signed-off-by: Jakub Kicinski

net: drop the weight argument from netif_napi_add

2022-09-29T01:57:14Z

We tell driver developers to always pass NAPI_POLL_WEIGHT as the weight to netif_napi_add(). This may be confusing to newcomers, drop the weight argument, those who really need to tweak the weight can use netif_napi_add_weight(). Acked-by: Marc Kleine-Budde # for CAN Link: https://lore.kernel.org/r/20220927132753.750069-1-kuba@kernel.org Signed-off-by: Jakub Kicinski

sunhme: Use vdbg for spam-y prints

2022-09-27T00:45:38Z

The SXD, TXD, and RXD macros are used only once (or twice). Just use the vdbg print, which seems to have been devised for these sorts of very verbose messages. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski

sunhme: Combine continued messages

2022-09-27T00:45:38Z

This driver seems to have been written under the assumption that messages can be continued arbitrarily. I'm not when this changed (if ever), but such ad-hoc continuations are liable to be rudely interrupted. Convert all such instances to single prints. This loses a bit of timing information (such as when a line was constructed piecemeal as the function executed), but it's easy to add a few prints if necessary. This also adds newlines to the ends of any prints without them. Since (almost every) debug print included the name of the function, include it automatically. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski

sunhme: Use (net)dev_foo wherever possible

2022-09-27T00:45:38Z

Wherever possible, use the associated netdev (or device) when printing errors or other messages. This makes it immediately clear what device caused the error, and provides more information than just the device name. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski

sunhme: Convert printk(KERN_FOO ...) to pr_foo(...)

2022-09-27T00:45:37Z

This is a mostly-mechanical translation of the existing printks into pr_foos. In several places, I have pasted messages which were broken over several lines to allow for easier grepping. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski

sunhme: Clean up debug infrastructure

2022-09-27T00:45:37Z

Remove all the single-use debug conditionals, and just collect the debug defines at the top of the file. HMD seems like it is used for general debug info, so just redefine it as pr_debug. Additionally, instead of using the default loglevel, use the debug loglevel for debugging. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski

sunhme: Convert FOO((...)) to FOO(...)

2022-09-27T00:45:37Z

With the power of variadic macros, double parentheses are unnecessary. Signed-off-by: Sean Anderson Signed-off-by: Jakub Kicinski