linux-dev/drivers/staging/iio/adc, branch master

iio:adc:ad7280a: Move out of staging

2022-02-21T19:33:05Z

This is a rather unusual device (in IIO anyway). However, it has a near to standard userspace ABI. Note the work to move this out of staging was done against a minimal QEMU model, which doesn't model all the features of the device. I have no intention to upstream the QEMU model as it was developed just to enable this driver cleanup. https://github.com/jic23/qemu/tree/ad7280a-hacks Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-21-jic23@kernel.org

staging:iio:adc:ad7280a: Use more conservative delays to allow 105C operation.

2022-02-21T19:33:05Z

The datasheet provides timings for operating this device at up to 105 degrees centigrade. Adopt these more conservative timings. Suggested-by: Marcelo Schmitt Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-20-jic23@kernel.org

staging:iio:adc:ad7280a: Remove shift from cb_mask state cache.

2022-02-21T19:33:05Z

Making the local storage of the Cell Balance mask a simple bitmap and then shifting it only at time of register write simplifies several code paths. Suggested-by: Marcelo Schmitt Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-19-jic23@kernel.org

staging:iio:adc:ad7280a: Drop buggy support for early termination of AUX alert.

2022-02-21T19:33:05Z

This functionality is intended to allow for a few temperature sensors to be missing (and hence not worth reading) on the final device in a chain. The ones removed are 3 and 5 (unlike for the ADC channels where it is 4 and 5). The datasheet includes a foot note 3 to Table 12 that makes this complex to support. "(3) To remove AUX5 or AUX5 and AUX3 from the alert detection, conversions on three auxiliary ADC input channels only must be selected in the control register." This mode has never been supported by the driver. As this support would be complex to add and the rework is being done against a QEMU model developed for the purposes of verifying nothing is broken, it is better to drop this support for now. Reported-by: Marcelo Schmitt Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-16-jic23@kernel.org

staging:iio:adc:ad7280a: Use device properties to replace platform data.

2022-02-21T19:33:05Z

Convert all the device specific info that was previously in platform data over to generic firmware query interfaces. dt-bindings to follow shortly. Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-15-jic23@kernel.org

staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev

2022-02-21T19:33:05Z

We use this a few times already and it is about to get worse, so introduce a local variable to simplify things. Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-14-jic23@kernel.org

staging:iio:ad7280a: Reflect optionality of irq in ABI

2022-02-21T19:33:05Z

Given the irq is optional, let us remove the interfaces related to events when it is not present. Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-13-jic23@kernel.org

staging:iio:adc:ad7280a: Cleanup includes

2022-02-21T19:33:05Z

Drop used includes, add a few missing ones and reorder. The include-what-you-use tool output was considered in making this change. Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-12-jic23@kernel.org

staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control

2022-02-21T19:33:04Z

Oversampling has nothing directly to do with analog circuits or similar so belongs in the control of userspace as a policy decision. The only complexity in here was that the acquisition time needs updating if this setting is changed at runtime (as oversampling is time consuming). Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-11-jic23@kernel.org

staging:iio:adc:ad7280a: Trivial comment formatting cleanup

2022-02-21T19:33:04Z

IIO uses the /* * stuff * more stuff */ multi-line style, so use that here as well. Signed-off-by: Jonathan Cameron Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20220206190328.333093-10-jic23@kernel.org