linux-dev/drivers/staging/mt7621-mmc, branch master

staging: m57621-mmc: delete driver from the tree.

2019-04-03T09:10:15Z

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place. Cc: Matthias Brugger Cc: NeilBrown Cc: George Hilliard Cc: "Christian Lütke-Stetzkamp" Cc: Nishad Kamdar Cc: Sergej Perschin Cc: John Crispin Signed-off-by: Greg Kroah-Hartman

staging: add missing SPDX lines to Kconfig files

2019-04-03T09:10:15Z

There are a few remaining drivers/staging/*/Kconfig files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-27T14:39:31Z

The module was initializing completions whenever it was going to wait on them, and not when the completion was allocated. This is incorrect according to the completion docs: Calling init_completion() on the same completion object twice is most likely a bug [...] Re-initialization is also unnecessary because the module never uses complete_all(). Fix this by only ever initializing the completion a single time, and log if the completions are not consumed as intended (this is not a fatal problem, but should not go unnoticed). Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Remove obsolete Kconfig flags

2019-03-27T14:37:30Z

These values are not referred to anywhere else in the kernel. Card detect is controlled by the device tree property "mediatek,cd-poll", and there is no driver support for eMMC whatsoever. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Check for nonzero number of scatterlist entries

2019-03-22T14:20:27Z

The buffer descriptor setup loop is correct only if it is setting up at least one bd struct. Besides, there is an error if dma_map_sg() returns 0, which is possible and must be handled. Additionally, remove the BUG_ON() checking sglen, which is unnecessary because we configure DMA with that constraint during init. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Fix warning when reloading module with debug msgs enabled

2019-03-22T14:20:27Z

The kernel complained: [ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 proc_register+0xf0/0x108 [ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered when doing a modprobe/rmmod/modprobe of this module if debug messages are compiled in. Fix this by removing the proc entry when the module is unloaded. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Only unmap_sg if mapped

2019-03-20T07:23:18Z

A failure while processing the start command could cause dma_unmap_sg() to be called without first calling dma_map_sg(). Since calling dma_unmap_sg() is only needed when data != NULL, move the unmap call into the corresponding if {} block. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Fix BRUST -> BURST typo

2019-03-20T07:23:18Z

Obvious typo. It is specified as BURST in the datasheet. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Immediately notify mmc layer of card change detection

2019-03-20T07:23:18Z

There is no need to delay notifying the mmc layer. Schedule the delayed work to run immediately. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman

staging: mt7621-mmc: Remove redundant host->mmc->f_max write

2019-03-20T07:23:18Z

This is set once during initialization and never changed. Don't bother setting it again in the interrupt handler. Signed-off-by: George Hilliard Signed-off-by: Greg Kroah-Hartman