linux-dev/drivers/staging/rtlwifi/halmac, branch master

staging: rtlwifi: delete the staging driver

2019-05-01T08:15:42Z

A "real" driver for this hardware is now in the wireless-drivers-next tree, to be merged in the next major kernel release, so this staging driver can now be deleted as it is not needed anymore. Note, 2 .h files remain for this driver, as they are referenced in a separate staging driver. That mess will be cleaned up in a follow-on patch. Cc: Ping-Ke Shih Cc: Tzu-En Huang Cc: Yan-Hsuan Chuang Cc: Stanislaw Gruszka Cc: Brian Norris Cc: Kalle Valo Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: halmac: halmac_api.c: Compress two lines into one line

2019-04-01T17:22:22Z

Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: halmac: Compress two lines into one line

2019-04-01T17:22:22Z

Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: halmac: halmac_88xx: Compress two lines into one line

2019-04-01T17:22:22Z

Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-21T09:58:11Z

Clang warns: drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11: warning: implicit conversion from enumeration type 'enum halmac_cmd_process_status' to different enumeration type 'enum halmac_ret_status' [-Wenum-conversion] return HALMAC_CMD_PROCESS_ERROR; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Fix this by using the proper enum for allocation failures, HALMAC_RET_MALLOC_FAIL, which is used in the rest of this file. Fixes: e4b08e16b7d9 ("staging: r8822be: check kzalloc return or bail") Link: https://github.com/ClangBuiltLinux/linux/issues/375 Signed-off-by: Nathan Chancellor Reviewed-by: Nicholas Mc Guire Signed-off-by: Greg Kroah-Hartman

staging: r8822be: check kzalloc return or bail

2019-02-19T10:12:08Z

The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL so check the psd_set->data after allocation and if allocation failed return HALMAC_CMD_PROCESS_ERROR. Signed-off-by: Nicholas Mc Guire Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-drive") Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Return -ENOMEM instead of -1

2018-10-02T22:18:36Z

Use the ENOMEM constant instead of -1 for kzalloc failure checks in rtl_halmac.c Signed-off-by: Aymen Qader Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Remove empty halmac_pcie_reg.h

2018-07-13T09:37:34Z

halmac_pcie_reg.h is empty, so remove it and the only include of it. Signed-off-by: Bjorn Helgaas Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Fix a possible sleep-in-atomic-context bug in _is_fw_read_cmd_down()

2018-06-28T13:10:51Z

The driver may sleep with holding a spinlock. The function call path (from bottom to top) in Linux-4.16.7 is: [FUNC] schedule drivers/staging/rtlwifi/halmac/rtl_halmac.c, 884: schedule in _is_fw_read_cmd_down drivers/staging/rtlwifi/halmac/rtl_halmac.c, 912: _is_fw_read_cmd_down in rtl_halmac_send_h2c drivers/staging/rtlwifi/halmac/rtl_halmac.c, 907: _raw_spin_lock_irqsave in rtl_halmac_send_h2c To fix this bug, schedule() is replaced with mdelay(1). This bug is found by my static analysis tool (DSAC-2) and checked by my code review. Signed-off-by: Jia-Ju Bai Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Replace license boilerplate with SPDX identifiers

2018-05-07T02:01:29Z

This satisfies a checkpatch.pl warning and is the preferred method for notating the license due to its lack of ambiguity. Signed-off-by: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman