linux-dev/drivers/staging/rts5208/ms.c, branch linus/master

staging: rts5208: fix Lines should not end with a '('.

2022-03-02T15:34:24Z

Fix the following check reported by checkpatch.pl: CHECK: Lines should not end with a '(' retval = ms_transfer_tpc( Signed-off-by: Samuel Sjöberg Link: https://lore.kernel.org/r/20220302150328.2722-1-info@samuelsjoberg.se Signed-off-by: Greg Kroah-Hartman

staging: rts5208: remove unnecessary parentheses in ms.c

2021-09-18T14:26:48Z

This commit removes unnecessary parentheses, that have been flagged by checkpatch.pl in ms.c Signed-off-by: Benjamin Philip Link: https://lore.kernel.org/r/20210918065744.26304-1-benjamin.philip495@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: remove redundant continue statement

2021-06-18T11:02:47Z

The continue statement at the end of a for-loop has no effect, remove it. Signed-off-by: Colin Ian King Addresses-Coverity: ("Continue has no effect") Link: https://lore.kernel.org/r/20210617120411.11612-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Use array_size() helper in vmalloc() and memset()

2020-06-18T07:57:57Z

The vmalloc() function has no 2-factor argument form, so multiplication factors need to be wrapped in array_size(). Also, while there, use array_size() in memset(). This issue was found with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva Link: https://lore.kernel.org/r/20200616175543.GA28687@embeddedor Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Eliminate the use of Camel Case in files ms.{h, c}

2019-11-01T09:53:16Z

Cleans up checks of "Avoid CamelCase" in files ms.{h,c} Signed-off-by: Gabriela Bittencourt Link: https://lore.kernel.org/r/20191031230243.3462-2-gabrielabittencourt00@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: remove redundant assignment to retval

2019-08-21T12:48:06Z

Variable retval is initialized to a value that is never read and it is re-assigned later. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20190818184649.13828-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Add a check for ms_read_extra_data

2019-01-07T07:56:07Z

In ms_copy_page, the function ms_read_extra_data may fail for many reasons. The fix adds a check similar to other invocation to return error upstream. Signed-off-by: Aditya Pakki Reviewed-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

Staging: rts5208: Add SPDX license tags

2018-11-05T13:16:33Z

Add SPDX license tags to remove checkpatch SPDX warnings. Signed-off-by: Kim Bradley Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Remove unnecessary braces {}

2018-09-25T19:10:36Z

This patch fixes the checkpatch.pl warning "braces {} are not necessary" in the rts5208 driver. Mostly applies to single-line return/goto if blocks. Signed-off-by: Aymen Qader Signed-off-by: Greg Kroah-Hartman

staging: rtsx: remove rtsx_trace() and related code

2018-06-28T13:10:47Z

The driver has rather excessive amount of tracing code, which would be better done using ftrace. This is obviously not a main feature of the driver, and it should work just as well without it. Removing it saves over 1300 lines of code and likely makes the driver a bit faster by avoiding lots of calls into the timekeeping code. I came across this while cleaning up the last users of the deprecated getnstimeofday64() function, of which there is one in the now-removed get_current_time() function of the rtsx driver that was only used for tracing. Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman