linux-dev/drivers/staging/rts5208/sd.c, branch linus/master

staging: rts5208: remove parentheses pair in sd.c

2021-09-21T15:30:55Z

I had missed a single parentheses pair in the commit for sd.c. This commit removes the pair I missed. Signed-off-by: Benjamin Philip Link: https://lore.kernel.org/r/4a56facd2c04a321b091d3b7dbea87168e8ddd6e.1632209460.git.benjamin.philip495@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: remove unnecessary parentheses in sd.c

2021-09-21T15:30:55Z

This commit removes unnecessary parentheses, that have been flagged by checkpatch.pl in sd.c Signed-off-by: Benjamin Philip Link: https://lore.kernel.org/r/b96aa1a0d9b306566a54d4b4643c06c520877042.1632209460.git.benjamin.philip495@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: remove redundant sd30_mode checks

2019-09-03T07:36:07Z

There are two hunks of code that check if sd30_mode is true however an earlier check in an outer code block on sd30_mode being false means that sd30_mode can never be true at these points so these checks are redundant. Remove the dead code. Addresses-Coverity: ("Logically dead code") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20190830081047.13630-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Rewrite redundant if statement to improve code style

2019-07-01T07:05:21Z

This commit uses the fact that if (a) { if (b) { ... } } can instead be written as if (a && b) { ... } without any change in behavior, allowing to decrease the indentation of the contained code block and thus reducing the average line length. Signed-off-by: Tobias Nießen Signed-off-by: Sabrina Gaube Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Remove function soft_reset_sd_card()

2019-06-20T12:45:03Z

Remove function soft_reset_sd_card, as all it does is call reset_sd. Modify call sites of the former to call the latter instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Signed-off-by: Greg Kroah-Hartman

Staging: rts5208: Fix error handling on rtsx_send_cmd

2019-01-07T10:28:15Z

In sd_execute_write_data, the rtsx_send_cmd could fail with ETIMEDOUT or EIO. The fix adds a check to handle these failures. Signed-off-by: Aditya Pakki Signed-off-by: Greg Kroah-Hartman

Staging: rts5208: Add SPDX license tags

2018-11-05T13:16:33Z

Add SPDX license tags to remove checkpatch SPDX warnings. Signed-off-by: Kim Bradley Signed-off-by: Greg Kroah-Hartman

staging: rts5208: Remove unnecessary braces {}

2018-09-25T19:10:36Z

This patch fixes the checkpatch.pl warning "braces {} are not necessary" in the rts5208 driver. Mostly applies to single-line return/goto if blocks. Signed-off-by: Aymen Qader Signed-off-by: Greg Kroah-Hartman

staging: rts5208: fix missing error check on call to rtsx_write_register

2018-07-06T15:37:31Z

Currently the check on error return from the call to rtsx_write_register is checking the error status from the previous call. Fix this by adding in the missing assignment of retval. Detected by CoverityScan, CID#709877 Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman

staging: rtsx: remove rtsx_trace() and related code

2018-06-28T13:10:47Z

The driver has rather excessive amount of tracing code, which would be better done using ftrace. This is obviously not a main feature of the driver, and it should work just as well without it. Removing it saves over 1300 lines of code and likely makes the driver a bit faster by avoiding lots of calls into the timekeeping code. I came across this while cleaning up the last users of the deprecated getnstimeofday64() function, of which there is one in the now-removed get_current_time() function of the rtsx driver that was only used for tracing. Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman