linux-dev/drivers/staging/silicom, branch master

staging: silicom: remove driver

2014-07-27T18:24:37Z

The driver hasn't been cleaned up and it doesn't look like anyone is working on it anymore (including the original author). So remove it. If someone wants to work on cleaning the driver up and moving it out of staging, this commit can be reverted. In addition, since this removes the CONFIG_NET_VENDOR_SILICOM config symbol, remove the symbol from all defconfig files that reference it. Signed-off-by: Kristina Martšenko Cc: Daniel Cotey Signed-off-by: Greg Kroah-Hartman

staging: silicom: fix sparse warning for static variable

2014-06-01T23:46:56Z

This patch fixes the following sparse warning in bpctl_mod.c: warning: symbol 'bpvm_lock' was not declared. Should it be static? Signed-off-by: James A Shackleford Signed-off-by: Greg Kroah-Hartman

staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions

2014-05-26T17:36:07Z

Originally, this header was defining two new typedefs, CMND_TYPE and CMND_TYPE_SD, following this type of declaration: typedef enum { ... } CMND_TYPE; A previous commit (785086556a573f07747b3633732a9dbd7e45728f) tried to fix warnings that were pointed out by checkpatch.pl, concerning not adding new typedefs. But this commit only removed the 'typedef' keyword, thus transforming both the typedefs into two the definition of global variables. For example: enum { ... } CMND_TYPE; As noticed by the Sparse tool, this patch removes those erroneous global variable definitions, and just leaves anonymous enum type definitions: enum { ... }; Signed-off-by: Joel Porquet Signed-off-by: Greg Kroah-Hartman

drivers/staging: Remove useless return variables

2014-05-26T17:32:15Z

This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Greg Kroah-Hartman

Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-26T17:30:23Z

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey Signed-off-by: Greg Kroah-Hartman

staging: silicom: Remove unused pointer in bypass_init_module()

2014-05-23T11:40:41Z

Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove it. With the last variable declaration gone, there is no more need for an own block. Remove it and adapt the indenting accordingly. Signed-off-by: Christian Engelmayer Reviewed-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: silicom: Remove needless calls of get_status_port_fn()

2014-05-23T11:40:41Z

Remove a needless pointer initialisation and call to get_status_port_fn() in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable 'pbpctl_dev_b' is set correctly later in the function before first use. Signed-off-by: Christian Engelmayer Signed-off-by: Greg Kroah-Hartman

staging: silicom: add blank line after declarations

2014-05-23T11:40:41Z

Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by: Fernando Apesteguia Signed-off-by: Greg Kroah-Hartman

staging: silicom: remove redundant pci_get_drvdata() call

2014-04-25T22:34:16Z

The pci_get_drvdata() and checking NULL for dev are called twice in while loop in is_bypass_dev(). Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

Staging: silicom: fix dangerous if condition in bpctl_mod.c

2014-04-25T22:33:35Z

checkpatch script returns the following warning: ERROR: do not use assignment in if condition + if (((dev_num = get_dev_idx(dev->ifindex)) == -1) | This patch fixes the if condition by splitting it. Signed-off-by: Neil Armstrong Signed-off-by: Greg Kroah-Hartman