linux-dev/sound/soc/amd/acp, branch master

ASoC: amd: acp: use function devm_kcalloc() instead of devm_kzalloc()

2022-09-19T16:52:40Z

Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot Signed-off-by: ye xingchen Link: https://lore.kernel.org/r/20220916062027.152815-1-ye.xingchen@zte.com.cn Signed-off-by: Mark Brown

ASoC: amd: acp: use devm_kcalloc() instead of devm_kzalloc()

2022-09-19T16:52:37Z

Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot Signed-off-by: ye xingchen Link: https://lore.kernel.org/r/20220916061906.152434-1-ye.xingchen@zte.com.cn Signed-off-by: Mark Brown

ASoC: amd: acp: Modify dai_id macros to be more generic

2022-08-28T21:04:03Z

Change dai_id macros to make I2S instances in order. Signed-off-by: Venkata Prasad Potturu Link: https://lore.kernel.org/r/20220826064250.3302260-1-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: remove unnecessary NULL checks

2022-08-19T12:20:00Z

The list iterator can never be NULL. Delete the bogus NULL checks. Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/Yv8ePUuBfzaRu6xV@kili Signed-off-by: Mark Brown

ASoC: amd: acp: add a label to make error path more clean

2022-08-19T12:19:58Z

Move platform_device_unregister() to a new label to make code more clean. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-3-yangyingliang@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: switch to use dev_err_probe()

2022-08-19T12:19:57Z

Use dev_err_probe() to simplify code and print error code. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-2-yangyingliang@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe()

2022-08-19T12:19:56Z

Add missing platform_device_unregister() in error path in acp_pci_probe(). Fixes: c49f5e74a11e ("ASoC: amd: acp: Add error handling cases") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-1-yangyingliang@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: Add TDM support for acp i2s stream

2022-08-15T00:19:42Z

Add callback and code changes to enable ACP I2S controller in TDM mode. Add new fields in acp_stream and acp_dev_data struct to configure tdm related registers for ACP i2s controllers. Signed-off-by: Venkata Prasad Potturu Link: https://lore.kernel.org/r/20220810132913.1181247-3-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: Initialize list to store acp_stream during pcm_open

2022-08-15T00:19:41Z

We are currently allocating acp_stream during pcm_open and saving it in static array corresponds to array index calculated based on cpu dai->driver id. This approach will fail if we have single dai linked to multiple pcm device as we will have same dai->driver id or array index for multiple pcm open. Initialize new linked list stream_list to store opened pcm stream info dynamically. Signed-off-by: Ajit Kumar Pandey Signed-off-by: Venkata Prasad Potturu Reviewed-by: Vijendar Mukunda Link: https://lore.kernel.org/r/20220810132913.1181247-2-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handler()

2022-07-26T12:02:25Z

Clang warns: ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized] if (stream && (ext_intr_stat1 & stream->irq_bit)) { ^~~~~~~~~~~~~~ ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning u32 ext_intr_stat, ext_intr_stat1, i; ^ = 0 1 error generated. The variable was not properly renamed, correct it to resolve the warning. Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic") Link: https://github.com/ClangBuiltLinux/linux/issues/1675 Signed-off-by: Nathan Chancellor Reviewed-by: Tom Rix Link: https://lore.kernel.org/r/20220725180539.1315066-1-nathan@kernel.org Signed-off-by: Mark Brown