linux-dev/sound/soc/soc-ops.c, branch linus/master

ASoC: ops: Validate input values in snd_soc_put_volsw_range()

2022-04-26T14:13:36Z

Check that values written via snd_soc_put_volsw_range() are within the range advertised by the control, ensuring that we don't write out of spec values to the hardware. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220423131239.3375261-1-broonie@kernel.org Signed-off-by: Mark Brown

ASoC: soc-ops: fix error handling

2022-04-21T17:25:12Z

cppcheck throws the following warning: sound/soc/soc-ops.c:461:8: style: Variable 'ret' is assigned a value that is never used. [unreadVariable] ret = err; ^ This seems to be a missing change in the return value. Fixes: 7f3d90a351968 ("ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx()") Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Rander Wang Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20220421162328.302017-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown

ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min

2022-02-16T16:33:48Z

While the $val/$val2 values passed in from userspace are always >= 0 integers, the limits of the control can be signed integers and the $min can be non-zero and less than zero. To correctly validate $val/$val2 against platform_max, add the $min offset to val first. Fixes: 817f7c9335ec0 ("ASoC: ops: Reject out of bounds values in snd_soc_put_volsw()") Signed-off-by: Marek Vasut Cc: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220215130645.164025-1-marex@denx.de Signed-off-by: Mark Brown

ASoC: ops: Fix stereo change notifications in snd_soc_put_xr_sx()

2022-02-02T16:09:20Z

When writing out a stereo control we discard the change notification from the first channel, meaning that events are only generated based on changes to the second channel. Ensure that we report a change if either channel has changed. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220201155629.120510-5-broonie@kernel.org Signed-off-by: Mark Brown

ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_range()

2022-02-02T16:09:19Z

ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx()

2022-02-02T16:09:18Z

ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw()

2022-02-02T16:09:16Z

ASoC: ops: Check for negative values before reading them

2022-01-28T20:55:39Z

The controls allow inputs to be specified as negative but our manipulating them into register fields need to be done on unsigned variables so the checks for negative numbers weren't taking effect properly. Do the checks for negative values on the variable in the ABI struct rather than on our local unsigned copy. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220128192443.3504823-1-broonie@kernel.org Signed-off-by: Mark Brown

ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()

2022-01-25T10:21:36Z

We don't currently validate that the values being set are within the range we advertised to userspace as being valid, do so and reject any values that are out of range. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220124153253.3548853-4-broonie@kernel.org Signed-off-by: Mark Brown

ASoC: ops: Reject out of bounds values in snd_soc_put_volsw_sx()

2022-01-25T10:21:34Z