Linux kernel development work - see feature branches https://git.zx2c4.com/linux-dev/atom/usr/gen_initramfs_list.sh?h=linus%2Fmaster 2020-01-14T01:42:44Z 2020-01-14T01:42:44Z Masahiro Yamada masahiroy@kernel.org 2020-01-04T15:02:29Z urn:sha1:80e715a06c2d0a24dbb818bb1dba2ef0f20d7068 The comments in usr/Makefile wrongly refer to the script name (twice). Line 37: # The dependency list is generated by gen_initramfs.sh -l Line 54: # 4) Arguments to gen_initramfs.sh changes There does not exist such a script. I was going to fix the comments, but after some consideration, I thought "gen_initramfs.sh" would be more suitable than "gen_initramfs_list.sh" because it generates an initramfs image in the common usage. The script generates a list that can be fed to gen_init_cpio only when it is directly run without -o or -l option. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 2020-01-14T01:42:44Z Masahiro Yamada masahiroy@kernel.org 2020-01-04T15:02:28Z urn:sha1:a4c968e70f68d81276def017fcb1468e3930aa1d There is no tool named "gen_initramfs". The correct name is "gen_init_cpio". Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Greg Thelen <gthelen@google.com> 2020-01-14T01:42:44Z Masahiro Yamada masahiroy@kernel.org 2020-01-04T15:02:27Z urn:sha1:9a04dc52982eb8f2ccd604b48f057217a39f243c This is assigned, but not referenced. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Greg Thelen <gthelen@google.com> 2020-01-03T15:00:48Z Masahiro Yamada masahiroy@kernel.org 2019-12-30T13:20:06Z urn:sha1:cc976614f59bd8e45de8ce988a6bcb5de711d994 Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension"), this shell script was almost always run by bash since bash is usually installed on the system by default. Now, this script is run by sh, which might be a symlink to dash. On such distributions, the following code emits an error: local dev=`LC_ALL=C ls -l "${location}"` You can reproduce the build error, for example by setting CONFIG_INITRAMFS_SOURCE="/dev". GEN usr/initramfs_data.cpio.gz ./usr/gen_initramfs_list.sh: 131: local: 1: bad variable name make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2 This is because `LC_ALL=C ls -l "${location}"` contains spaces. Surrounding it with double-quotes fixes the error. Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension") Reported-by: Jory A. Pratt <anarchy@gentoo.org> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 2018-08-22T14:21:44Z Masahiro Yamada yamada.masahiro@socionext.com 2018-08-20T15:29:51Z urn:sha1:f6f57a46435d7253a52a1a07a58183678ad266a0 scripts/gen_initramfs_list.sh is only invoked from usr/Makefile. Move it so that all tools to create initramfs are self-contained in the usr/ directory. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>