aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-07-17 17:12:39 +0100
committerDavid S. Miller <davem@davemloft.net>2018-07-18 15:11:09 -0700
commit169dc027fb02492ea37a0575db6a658cf922b854 (patch)
treebdce1d5bf96d8b9d66439aa0088590e08167afb9
parentipv6: sr: fix useless rol32 call on hash (diff)
downloadlinux-dev-169dc027fb02492ea37a0575db6a658cf922b854.tar.xz
linux-dev-169dc027fb02492ea37a0575db6a658cf922b854.zip
ipv6: fix useless rol32 call on hash
The rol32 call is currently rotating hash but the rol'd value is being discarded. I believe the current code is incorrect and hash should be assigned the rotated value returned from rol32. Thanks to David Lebrun for spotting this. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/net/ipv6.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 7528632bcf2a..8f73be494503 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -823,7 +823,7 @@ static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb,
* to minimize possbility that any useful information to an
* attacker is leaked. Only lower 20 bits are relevant.
*/
- rol32(hash, 16);
+ hash = rol32(hash, 16);
flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK;