aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2017-06-11 23:18:16 +0200
committerJason A. Donenfeld <Jason@zx2c4.com>2017-06-11 23:19:25 +0200
commit811c254202498b4c7f5fd1ad7b04157b97eaa427 (patch)
treedbd1fa69abbbdf3e51db72207fbf275818513562
parentmac80211/wpa: use constant time memory comparison for MACs (diff)
downloadlinux-dev-jd/variable-time-memcmp.tar.xz
linux-dev-jd/variable-time-memcmp.zip
rsa-pkcs1pad: use constant time memory comparison for MACsjd/variable-time-memcmp
Otherwise, we enable all sorts of forgeries via timing attack. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Suggested-by: Stephan Müller <smueller@chronox.de> Cc: stable@vger.kernel.org Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: linux-crypto@vger.kernel.org
-rw-r--r--crypto/rsa-pkcs1pad.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/rsa-pkcs1pad.c b/crypto/rsa-pkcs1pad.c
index 8baab4307f7b..7830d304dff6 100644
--- a/crypto/rsa-pkcs1pad.c
+++ b/crypto/rsa-pkcs1pad.c
@@ -496,7 +496,7 @@ static int pkcs1pad_verify_complete(struct akcipher_request *req, int err)
goto done;
pos++;
- if (memcmp(out_buf + pos, digest_info->data, digest_info->size))
+ if (crypto_memneq(out_buf + pos, digest_info->data, digest_info->size))
goto done;
pos += digest_info->size;