aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOlga Kornievskaia <olga.kornievskaia@gmail.com>2019-12-04 15:13:54 -0500
committerJ. Bruce Fields <bfields@redhat.com>2019-12-07 11:28:46 -0500
commit18f428d4e2f7eff162d80b2b21689496c4e82afd (patch)
tree7e65826fb0d6e60556396e6dbed892616c739d7f
parentnfsd: check for EBUSY from vfs_rmdir/vfs_unink. (diff)
downloadlinux-dev-18f428d4e2f7eff162d80b2b21689496c4e82afd.tar.xz
linux-dev-18f428d4e2f7eff162d80b2b21689496c4e82afd.zip
NFSD fixing possible null pointer derefering in copy offload
Static checker revealed possible error path leading to possible NULL pointer dereferencing. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: e0639dc5805a: ("NFSD introduce async copy feature") Signed-off-by: Olga Kornievskaia <kolga@netapp.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfs4proc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 38c0aeda500e..4798667af647 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1298,7 +1298,8 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
out:
return status;
out_err:
- cleanup_async_copy(async_copy);
+ if (async_copy)
+ cleanup_async_copy(async_copy);
goto out;
}