aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2017-04-05 14:39:35 -0700
committerDavid S. Miller <davem@davemloft.net>2017-04-06 13:38:11 -0700
commit129858fa0b1ab3072155718b74bf91e440c2d73f (patch)
tree4dcabb3070e1685f0b903f4d8ee918afda0a9fdd
parentqlge: avoid format string exposure in workqueue (diff)
downloadlinux-dev-129858fa0b1ab3072155718b74bf91e440c2d73f.tar.xz
linux-dev-129858fa0b1ab3072155718b74bf91e440c2d73f.zip
net: ethernet: wiznet: avoid format string exposure
While unlikely, this makes sure any format strings in the device name can't exposure information via the resulting workqueue name. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/wiznet/w5100.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index f90267f0519f..2bdfb39215e9 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct w5100_ops *ops,
if (err < 0)
goto err_register;
- priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+ priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+ netdev_name(ndev));
if (!priv->xfer_wq) {
err = -ENOMEM;
goto err_wq;