diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-05-21 08:33:01 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-05-22 21:47:57 +0100 |
| commit | 15d221d0c345b76947911a3ac91897ffe2f1cc4e (patch) | |
| tree | 4a44bff3940e18c765fa867c7de3aca007d082d7 | |
| parent | net: fec: Do proper error checking for optional clks (diff) | |
| download | linux-dev-15d221d0c345b76947911a3ac91897ffe2f1cc4e.tar.xz linux-dev-15d221d0c345b76947911a3ac91897ffe2f1cc4e.zip | |
hinic: Avoid some over memory allocation
'prod_idx' (atomic_t) is larger than 'shadow_idx' (u16), so some memory is
over-allocated.
Fixes: b15a9f37be2b ("net-next/hinic: Add wq")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c index f7dc7d825f63..4daf6bf291ec 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c @@ -386,7 +386,7 @@ static int alloc_wqes_shadow(struct hinic_wq *wq) return -ENOMEM; wq->shadow_idx = devm_kcalloc(&pdev->dev, wq->num_q_pages, - sizeof(wq->prod_idx), GFP_KERNEL); + sizeof(*wq->shadow_idx), GFP_KERNEL); if (!wq->shadow_idx) goto err_shadow_idx; |