aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDon Brace <don.brace@microsemi.com>2019-07-24 17:08:12 -0500
committerMartin K. Petersen <martin.petersen@oracle.com>2019-07-30 12:40:36 -0400
commit18a56d699d174f3ac41f2ea86e1ca21f98b01d8f (patch)
tree97f09911e7d2225d4c299a3dddb570963d3d1d32
parentscsi: hpsa: correct scsi command status issue after reset (diff)
downloadlinux-dev-18a56d699d174f3ac41f2ea86e1ca21f98b01d8f.tar.xz
linux-dev-18a56d699d174f3ac41f2ea86e1ca21f98b01d8f.zip
scsi: hpsa: remove printing internal cdb on tag collision
Remove racy printing of internal commands. Completion thread can be cleaning up the command in parallel. Reviewed-by: Bader Ali - Saleh <bader.alisaleh@microsemi.com> Reviewed-by: Scott Teel <scott.teel@microsemi.com> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com> Signed-off-by: Don Brace <don.brace@microsemi.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to '')
-rw-r--r--drivers/scsi/hpsa.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 89e71ebc5964..bba099e53266 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6091,8 +6091,6 @@ static struct CommandList *cmd_tagged_alloc(struct ctlr_info *h,
if (idx != h->last_collision_tag) { /* Print once per tag */
dev_warn(&h->pdev->dev,
"%s: tag collision (tag=%d)\n", __func__, idx);
- if (c->scsi_cmd != NULL)
- scsi_print_command(c->scsi_cmd);
if (scmd)
scsi_print_command(scmd);
h->last_collision_tag = idx;