diff options
| author |   Yang Shi <yang.shi@linux.alibaba.com> | 2019-11-30 17:51:26 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2019-12-01 06:29:19 -0800 |
| commit | 30c46382855e0e1b8a5c21331076feb190524546 (patch) | |
| tree | 32c40f48ec42f268081b041e28076156262b0d08 | |
| parent | mm/rmap.c: fix outdated comment in page_get_anon_vma() (diff) | |
| download | linux-dev-30c46382855e0e1b8a5c21331076feb190524546.tar.xz linux-dev-30c46382855e0e1b8a5c21331076feb190524546.zip | |
mm/rmap.c: use VM_BUG_ON_PAGE() in __page_check_anon_rmap()
The __page_check_anon_rmap() just calls two BUG_ON()s protected by
CONFIG_DEBUG_VM, the #ifdef could be eliminated by using VM_BUG_ON_PAGE().
Link: http://lkml.kernel.org/r/1573157346-111316-1-git-send-email-yang.shi@linux.alibaba.com
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | mm/rmap.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/mm/rmap.c b/mm/rmap.c index 0b00c20fdb0b..72a3280b982e 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1075,7 +1075,6 @@ static void __page_set_anon_rmap(struct page *page, static void __page_check_anon_rmap(struct page *page, struct vm_area_struct *vma, unsigned long address) { -#ifdef CONFIG_DEBUG_VM /* * The page's anon-rmap details (mapping and index) are guaranteed to * be set up correctly at this point. @@ -1088,9 +1087,9 @@ static void __page_check_anon_rmap(struct page *page, * are initially only visible via the pagetables, and the pte is locked * over the call to page_add_new_anon_rmap. */ - BUG_ON(page_anon_vma(page)->root != vma->anon_vma->root); - BUG_ON(page_to_pgoff(page) != linear_page_index(vma, address)); -#endif + VM_BUG_ON_PAGE(page_anon_vma(page)->root != vma->anon_vma->root, page); + VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address), + page); } /** |