aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAvi Kivity <avi@qumranet.com>2007-02-26 16:29:43 +0200
committerAvi Kivity <avi@qumranet.com>2007-03-04 11:12:43 +0200
commit58e690e6fd47a682b49aed3510443d6797a03021 (patch)
tree9859df2f04f05a8c2c470ccf18abea5ff1f51d89
parentKVM: Remove write access permissions when dirty-page-logging is enabled (diff)
downloadlinux-dev-58e690e6fd47a682b49aed3510443d6797a03021.tar.xz
linux-dev-58e690e6fd47a682b49aed3510443d6797a03021.zip
KVM: Fix bogus failure in kvm.ko module initialization
A bogus 'return r' can cause an otherwise successful module load to fail. This both denies users the use of kvm, and it also denies them the use of their machine, as it leaves a filesystem registered with its callbacks pointing into now-freed module memory. Fix by returning a zero like a good module. Thanks to Richard Lucassen <mailinglists@lucassen.org> (?) for reporting the problem and for providing access to a machine which exhibited it. Signed-off-by: Avi Kivity <avi@qumranet.com>
-rw-r--r--drivers/kvm/kvm_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index e48b4d7a350e..ca82ba359e1a 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2540,7 +2540,7 @@ static __init int kvm_init(void)
bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT;
memset(__va(bad_page_address), 0, PAGE_SIZE);
- return r;
+ return 0;
out:
kvm_exit_debug();