aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-07-09 23:51:54 +0000
committerDavid S. Miller <davem@davemloft.net>2010-07-12 20:21:43 -0700
commit5c4bfa17f3ec46becec4b23d12323f7605ebd696 (patch)
tree8133f3d0ef59f7198ff57cea3f813017708c3ba0
parenttc35815: fix iomap leak (diff)
downloadlinux-dev-5c4bfa17f3ec46becec4b23d12323f7605ebd696.tar.xz
linux-dev-5c4bfa17f3ec46becec4b23d12323f7605ebd696.zip
9p: strlen() doesn't count the terminator
This is an off by one bug because strlen() doesn't count the NULL terminator. We strcpy() addr into a fixed length array of size UNIX_PATH_MAX later on. The addr variable is the name of the device being mounted. CC: stable@kernel.org Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/9p/trans_fd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 98ce9bcb0e15..c85109d809ca 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args)
csocket = NULL;
- if (strlen(addr) > UNIX_PATH_MAX) {
+ if (strlen(addr) >= UNIX_PATH_MAX) {
P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n",
addr);
return -ENAMETOOLONG;