aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@ftp.linux.org.uk>2005-09-30 03:36:50 +0100
committerLinus Torvalds <torvalds@g5.osdl.org>2005-09-30 08:42:24 -0700
commitc215a16a4ad620b612b51495cbb99dbbb59bb585 (patch)
treec6abecc19111e112cd1825cab2e0e9d7d12e507b
parent[PATCH] uml get_user() NULL noise removal (diff)
downloadlinux-dev-c215a16a4ad620b612b51495cbb99dbbb59bb585.tar.xz
linux-dev-c215a16a4ad620b612b51495cbb99dbbb59bb585.zip
[PATCH] bogus BUILD_BUG_ON() in bpa_iommu
BUILD_BUG_ON(1) is asking for trouble (and getting it) when used in that manner - dead code elimination happens after we parse it and invalid type is invalid type, dead code or not. It might be version-dependent, but at least 4.0.1 refuses to accept that. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to '')
-rw-r--r--arch/ppc64/kernel/bpa_iommu.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/arch/ppc64/kernel/bpa_iommu.c b/arch/ppc64/kernel/bpa_iommu.c
index f33a7bccb0d7..507eb9d0223f 100644
--- a/arch/ppc64/kernel/bpa_iommu.c
+++ b/arch/ppc64/kernel/bpa_iommu.c
@@ -99,7 +99,11 @@ get_iost_entry(unsigned long iopt_base, unsigned long io_address, unsigned page_
break;
default: /* not a known compile time constant */
- BUILD_BUG_ON(1);
+ {
+ /* BUILD_BUG_ON() is not usable here */
+ extern void __get_iost_entry_bad_page_size(void);
+ __get_iost_entry_bad_page_size();
+ }
break;
}