diff options
author | Gustavo Romero <gromero@linux.vnet.ibm.com> | 2017-08-22 17:20:09 -0400 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2017-10-06 22:12:55 +1100 |
commit | 044215d145a7a8a60ffa8fdc859d110a795fa6ea (patch) | |
tree | 69c06d82fa7a2313c8a076f8910b61236177aa79 /Kconfig | |
parent | powerpc/64s: Use emergency stack for kernel TM Bad Thing program checks (diff) | |
download | linux-dev-044215d145a7a8a60ffa8fdc859d110a795fa6ea.tar.xz linux-dev-044215d145a7a8a60ffa8fdc859d110a795fa6ea.zip |
powerpc/tm: Fix illegal TM state in signal handler
Currently it's possible that on returning from the signal handler
through the restore_tm_sigcontexts() code path (e.g. from a signal
caught due to a `trap` instruction executed in the middle of an HTM
block, or a deliberately constructed sigframe) an illegal TM state
(like TS=10 TM=0, i.e. "T0") is set in SRR1 and when `rfid` sets
implicitly the MSR register from SRR1 register on return to userspace
it causes a TM Bad Thing exception.
That illegal state can be set (a) by a malicious user that disables
the TM bit by tweaking the bits in uc_mcontext before returning from
the signal handler or (b) by a sufficient number of context switches
occurring such that the load_tm counter overflows and TM is disabled
whilst in the signal handler.
This commit fixes the illegal TM state by ensuring that TM bit is
always enabled before we return from restore_tm_sigcontexts(). A small
comment correction is made as well.
Fixes: 5d176f751ee3 ("powerpc: tm: Enable transactional memory (TM) lazily for userspace")
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: Gustavo Romero <gromero@linux.vnet.ibm.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions