aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/kernel/signal.c
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2021-11-29 13:06:47 +0000
committerThomas Gleixner <tglx@linutronix.de>2021-12-01 00:06:43 +0100
commit050e22bfc4f450d342dbb7eaea470858ad567bce (patch)
tree6149685f1303bd2a3f7d38d9baadc907a319bf6d /arch/arm/kernel/signal.c
parentalpha: Snapshot thread flags (diff)
downloadlinux-dev-050e22bfc4f450d342dbb7eaea470858ad567bce.tar.xz
linux-dev-050e22bfc4f450d342dbb7eaea470858ad567bce.zip
ARM: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled, the flags can change under our feet. Generally this is unlikely to cause a problem in practice, but it is somewhat unsound, and KCSAN will legitimately warn that there is a data race. To avoid such issues, a snapshot of the flags has to be taken prior to using them. Some places already use READ_ONCE() for that, others do not. Convert them all to the new flag accessor helpers. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Paul E. McKenney <paulmck@kernel.org> Cc: Russell King <linux@armlinux.org.uk> Link: https://lore.kernel.org/r/20211129130653.2037928-6-mark.rutland@arm.com
Diffstat (limited to '')
-rw-r--r--arch/arm/kernel/signal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index a41e27ace391..c532a6041066 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -631,7 +631,7 @@ do_work_pending(struct pt_regs *regs, unsigned int thread_flags, int syscall)
}
}
local_irq_disable();
- thread_flags = current_thread_info()->flags;
+ thread_flags = read_thread_flags();
} while (thread_flags & _TIF_WORK_MASK);
return 0;
}