diff options
| author |   Daniel Mack <daniel@zonque.org> | 2018-07-06 22:15:00 +0200 |
|---|---|---|
| committer |   Robert Jarzmik <robert.jarzmik@free.fr> | 2018-07-07 13:25:15 +0200 |
| commit | 0c1049dcb4ceec640d8bd797335bcbebdcab44d2 (patch) | |
| tree | e8f821ed2fb82ce7ec966d663eb96f7aa8fab358 /arch/arm/mach-pxa/irq.c | |
| parent | Linux 4.18-rc1 (diff) | |
| download | linux-dev-0c1049dcb4ceec640d8bd797335bcbebdcab44d2.tar.xz linux-dev-0c1049dcb4ceec640d8bd797335bcbebdcab44d2.zip | |
ARM: pxa: irq: fix handling of ICMR registers in suspend/resume
PXA3xx platforms have 56 interrupts that are stored in two ICMR
registers. The code in pxa_irq_suspend() and pxa_irq_resume() however
does a simple division by 32 which only leads to one register being
saved at suspend and restored at resume time. The NAND interrupt
setting, for instance, is lost.
Fix this by using DIV_ROUND_UP() instead.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Diffstat (limited to '')
| -rw-r--r-- | arch/arm/mach-pxa/irq.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c index 9c10248fadcc..4e8c2116808e 100644 --- a/arch/arm/mach-pxa/irq.c +++ b/arch/arm/mach-pxa/irq.c @@ -185,7 +185,7 @@ static int pxa_irq_suspend(void) { int i; - for (i = 0; i < pxa_internal_irq_nr / 32; i++) { + for (i = 0; i < DIV_ROUND_UP(pxa_internal_irq_nr, 32); i++) { void __iomem *base = irq_base(i); saved_icmr[i] = __raw_readl(base + ICMR); @@ -204,7 +204,7 @@ static void pxa_irq_resume(void) { int i; - for (i = 0; i < pxa_internal_irq_nr / 32; i++) { + for (i = 0; i < DIV_ROUND_UP(pxa_internal_irq_nr, 32); i++) { void __iomem *base = irq_base(i); __raw_writel(saved_icmr[i], base + ICMR); |