aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm64/net/bpf_jit_comp.c
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2014-09-11 10:36:48 +0100
committerCatalin Marinas <catalin.marinas@arm.com>2014-09-12 16:33:14 +0100
commit60ef0494f197d4705b17132ee7d496283b5604b3 (patch)
tree71351c6dbc12734b66b6239187928c8c4664b475 /arch/arm64/net/bpf_jit_comp.c
parentMerge arm64 CPU suspend branch (diff)
downloadlinux-dev-60ef0494f197d4705b17132ee7d496283b5604b3.tar.xz
linux-dev-60ef0494f197d4705b17132ee7d496283b5604b3.zip
net: bpf: arm64: fix module memory leak when JIT image build fails
On ARM64, when the BPF JIT compiler fills the JIT image body with opcodes during translation of eBPF into ARM64 opcodes, we may fail for several reasons during that phase: one being that we jump to the notyet label for not yet supported eBPF instructions such as BPF_ST. In that case we only free offsets, but not the actual allocated target image where opcodes are being stored. Fix it by calling module_free() on dismantle time in case of errors. Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Acked-by: Zi Shen Lim <zlim.lnx@gmail.com> Acked-by: Will Deacon <will.deacon@arm.com> Cc: Alexei Starovoitov <ast@plumgrid.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'arch/arm64/net/bpf_jit_comp.c')
-rw-r--r--arch/arm64/net/bpf_jit_comp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index 38c42965382d..7ae33545535b 100644
--- a/arch/arm64/net/bpf_jit_comp.c
+++ b/arch/arm64/net/bpf_jit_comp.c
@@ -651,8 +651,10 @@ void bpf_int_jit_compile(struct bpf_prog *prog)
build_prologue(&ctx);
ctx.body_offset = ctx.idx;
- if (build_body(&ctx))
+ if (build_body(&ctx)) {
+ module_free(NULL, ctx.image);
goto out;
+ }
build_epilogue(&ctx);