aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm64/xen/hypercall.S
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2014-04-22 13:49:40 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-04-22 13:49:40 -0700
commit1b17844b29ae042576bea588164f2f1e9590a8bc (patch)
treeca1751393012b54f7be0b5b1750299e4e2ff4a8a /arch/arm64/xen/hypercall.S
parentMerge tag 'gpio-v3.15-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio (diff)
downloadlinux-dev-1b17844b29ae042576bea588164f2f1e9590a8bc.tar.xz
linux-dev-1b17844b29ae042576bea588164f2f1e9590a8bc.zip
mm: make fixup_user_fault() check the vma access rights too
fixup_user_fault() is used by the futex code when the direct user access fails, and the futex code wants it to either map in the page in a usable form or return an error. It relied on handle_mm_fault() to map the page, and correctly checked the error return from that, but while that does map the page, it doesn't actually guarantee that the page will be mapped with sufficient permissions to be then accessed. So do the appropriate tests of the vma access rights by hand. [ Side note: arguably handle_mm_fault() could just do that itself, but we have traditionally done it in the caller, because some callers - notably get_user_pages() - have been able to access pages even when they are mapped with PROT_NONE. Maybe we should re-visit that design decision, but in the meantime this is the minimal patch. ] Found by Dave Jones running his trinity tool. Reported-by: Dave Jones <davej@redhat.com> Acked-by: Hugh Dickins <hughd@google.com> Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions