diff options
| author |   Manish Ahuja <ahuja@austin.ibm.com> | 2007-07-10 05:03:45 +1000 |
|---|---|---|
| committer |   Paul Mackerras <paulus@samba.org> | 2007-07-26 16:12:17 +1000 |
| commit | 56d6d1a73d9e5ddd9eb1a7baeeda30803ba44879 (patch) | |
| tree | ee62e972dd751737d93d7a6d14b908b99067d391 /arch/powerpc/mm | |
| parent | Revert "[POWERPC] Don't complain if size-cells == 0 in prom_parse()" (diff) | |
| download | linux-dev-56d6d1a73d9e5ddd9eb1a7baeeda30803ba44879.tar.xz linux-dev-56d6d1a73d9e5ddd9eb1a7baeeda30803ba44879.zip | |
[POWERPC] Fix loop with unsigned long counter variable
This fixes a possible infinite loop when the unsigned long counter "i"
is used in lmb_add_region() in the following for loop:
for (i = rgn->cnt-1; i >= 0; i--)
by making the loop counter "i" be signed.
Signed-off-by: Manish Ahuja <ahuja@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/mm')
| -rw-r--r-- | arch/powerpc/mm/lmb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/mm/lmb.c b/arch/powerpc/mm/lmb.c index e3a1e8dc536a..8f4d2dc4cafb 100644 --- a/arch/powerpc/mm/lmb.c +++ b/arch/powerpc/mm/lmb.c @@ -138,8 +138,8 @@ void __init lmb_analyze(void) static long __init lmb_add_region(struct lmb_region *rgn, unsigned long base, unsigned long size) { - unsigned long i, coalesced = 0; - long adjacent; + unsigned long coalesced = 0; + long adjacent, i; /* First try and coalesce this LMB with another. */ for (i=0; i < rgn->cnt; i++) { |