diff options
| author |   Li Zefan <lizf@cn.fujitsu.com> | 2007-12-06 20:33:14 +1100 |
|---|---|---|
| committer |   Paul Mackerras <paulus@samba.org> | 2007-12-20 17:13:34 +1100 |
| commit | 6c6199c1551b7acd4f7898f073b40ae565d3b834 (patch) | |
| tree | 5d69f734a8dae8430744ff9699ea331f42e70dff /arch/ppc/syslib | |
| parent | [POWERPC] CHRP: Fix possible NULL pointer dereference (diff) | |
| download | linux-dev-6c6199c1551b7acd4f7898f073b40ae565d3b834.tar.xz linux-dev-6c6199c1551b7acd4f7898f073b40ae565d3b834.zip | |
[POWERPC] Don't cast a struct pointer to list_head pointer
The casting is safe only when the list_head member is the first member
of the structure, and even then it is better to use the address of the
list_head structure member.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/ppc/syslib')
| -rw-r--r-- | arch/ppc/syslib/ocp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c index 3f5be2c5ce99..d42d4085dc81 100644 --- a/arch/ppc/syslib/ocp.c +++ b/arch/ppc/syslib/ocp.c @@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int function, int index) down_write(&ocp_devices_sem); dev = __ocp_find_device(vendor, function, index); - list_del((struct list_head *)dev); + list_del(&dev->link); up_write(&ocp_devices_sem); DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... done.\n", vendor, function, index)); |