diff options
| author |   Heiko Carstens <hca@linux.ibm.com> | 2022-10-30 19:22:02 +0100 |
|---|---|---|
| committer |   Alexander Gordeev <agordeev@linux.ibm.com> | 2022-11-08 19:32:32 +0100 |
| commit | 80ddf5ce1c9291cb175d52ed1227134ad48c47ee (patch) | |
| tree | e3a4a2661afdd032707d48b1f1353d024c0b5256 /arch/s390/boot/startup.c | |
| parent | s390/configs: add kasan.config addon config file (diff) | |
| download | linux-dev-80ddf5ce1c9291cb175d52ed1227134ad48c47ee.tar.xz linux-dev-80ddf5ce1c9291cb175d52ed1227134ad48c47ee.zip | |
s390: always build relocatable kernel
Nathan Chancellor reported several link errors on s390 with
CONFIG_RELOCATABLE disabled, after binutils commit 906f69cf65da ("IBM
zSystems: Issue error for *DBL relocs on misaligned symbols"). The binutils
commit reveals potential miscompiles that might have happened already
before with linker script defined symbols at odd addresses.
A similar bug was recently fixed in the kernel with commit c9305b6c1f52
("s390: fix nospec table alignments").
See https://github.com/ClangBuiltLinux/linux/issues/1747 for an analysis
from Ulich Weigand.
Therefore always build a relocatable kernel to avoid this problem. There is
hardly any use-case for non-relocatable kernels, so this shouldn't be
controversial.
Link: https://github.com/ClangBuiltLinux/linux/issues/1747
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20221030182202.2062705-1-hca@linux.ibm.com
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Diffstat (limited to '')
| -rw-r--r-- | arch/s390/boot/startup.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c index 6e7f01ca53e6..47ca3264c023 100644 --- a/arch/s390/boot/startup.c +++ b/arch/s390/boot/startup.c @@ -291,8 +291,7 @@ void startup_kernel(void) clear_bss_section(); copy_bootdata(); - if (IS_ENABLED(CONFIG_RELOCATABLE)) - handle_relocs(__kaslr_offset); + handle_relocs(__kaslr_offset); if (__kaslr_offset) { /* |