diff options
| author |   Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-05-30 12:58:00 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-05-30 16:26:01 -0400 |
| commit | b4946ffb1860597b187d78d61ac6504177eb0ff8 (patch) | |
| tree | 56e5df1992aa478b806e5a768eda668543a5bb89 /arch/s390/hypfs | |
| parent | fix possible null ptr deref in kallsyms_lookup (diff) | |
| download | linux-dev-b4946ffb1860597b187d78d61ac6504177eb0ff8.tar.xz linux-dev-b4946ffb1860597b187d78d61ac6504177eb0ff8.zip | |
NFS: Fix a refcount leakage in O_DIRECT
The current code is leaking a reference to dreq->kref when the calls to
nfs_direct_read_schedule() and nfs_direct_write_schedule() return an
error.
This patch moves the call to kref_put() from nfs_direct_wait() back into
nfs_direct_read() and nfs_direct_write() (which are the functions that
actually took the reference in the first place) fixing the leak.
Thanks to Denis V. Lunev for spotting the bug and proposing the original
fix.
Acked-by: Denis V. Lunev <dlunev@gmail.com>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions